You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/04 11:51:51 UTC
[GitHub] [dolphinscheduler] Radeity opened a new issue, #12713: [Improvement][API] Check valid parameters when defining process
Radeity opened a new issue, #12713:
URL: https://github.com/apache/dolphinscheduler/issues/12713
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
When users define `parameter context` or `global parameter` in process, sometimes parameters are invalid for the sake of wrong parameter name or even parameter undefined. In current version, these error can only be found during executing the process, thus, i think a check when defining process is strongly needed.
I'll add function `checkValidParams` which will be called in the following methods in `ProcessDefinitionServiceImpl`:
```java
public Map<String, Object> createProcessDefinition(User loginUser, ...)
public Map<String, Object> updateProcessDefinition(User loginUser, ...)
```
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Radeity commented on issue #12713: [Improvement][API] Check valid parameters when defining process
Posted by GitBox <gi...@apache.org>.
Radeity commented on issue #12713:
URL: https://github.com/apache/dolphinscheduler/issues/12713#issuecomment-1304414948
@SbloodyS I'll close this issue and open a new one, i explain why in the new issue https://github.com/apache/dolphinscheduler/issues/12723.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #12713: [Improvement][API] Check valid parameters when defining process
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #12713:
URL: https://github.com/apache/dolphinscheduler/issues/12713#issuecomment-1303547532
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Radeity closed issue #12713: [Improvement][API] Check valid parameters when defining process
Posted by GitBox <gi...@apache.org>.
Radeity closed issue #12713: [Improvement][API] Check valid parameters when defining process
URL: https://github.com/apache/dolphinscheduler/issues/12713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Radeity commented on issue #12713: [Improvement][dolphinscheduler-api] Check valid primitive type parameters when defining process
Posted by GitBox <gi...@apache.org>.
Radeity commented on issue #12713:
URL: https://github.com/apache/dolphinscheduler/issues/12713#issuecomment-1317967932
Hi, @SbloodyS
In shell task, DS supports to use parameters like `echo ${val}`. However, we can't find out whether variable `val` is defined in upstream tasks or in worker's env variables, which means, use `DFS` or `TopSort` to find whether current parameters appear before may causes error because we don't know what env variables user defines.
I suggest to add explicit statement when using upstream task parameter like FILE type parameter(https://github.com/apache/dolphinscheduler/pull/12552), use `${taskName.Key}` and set directory `IN` to define a parameter input from upstream task. It's more clear and can be used to parameter check. WDYT? If you think it's reasonable, i'll create new issue and change definition of file type input parameter from `taskName.Key` to `${taskName.Key}`, either.
<img width="1183" alt="image" src="https://user-images.githubusercontent.com/45198818/202337422-1bc55bea-ca98-4cce-8cb3-dbfa6382bec4.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Radeity closed issue #12713: [Improvement][dolphinscheduler-api] Check valid primitive type parameters when defining process
Posted by GitBox <gi...@apache.org>.
Radeity closed issue #12713: [Improvement][dolphinscheduler-api] Check valid primitive type parameters when defining process
URL: https://github.com/apache/dolphinscheduler/issues/12713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org