You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/11/12 15:13:54 UTC
[GitHub] [cloudstack] DaanHoogland opened a new pull request #4030: some minor changes to make the build run with python 3
DaanHoogland opened a new pull request #4030:
URL: https://github.com/apache/cloudstack/pull/4030
## Description
<!--- Describe your changes in detail -->
print as method
async keyword use in variable name fixed
urllib openurl from urllib2 to urllib.request
This PR covers partially issue #3195.
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #4030: some minor changes to make the build run with python 3
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #4030:
URL: https://github.com/apache/cloudstack/pull/4030
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4030: some minor changes to make the build run with python 3
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4030:
URL: https://github.com/apache/cloudstack/pull/4030#discussion_r465751633
##########
File path: tools/apidoc/gen_toc.py
##########
@@ -245,10 +245,10 @@ def choose_category(fn):
def xml_for(command):
name = command['name']
- async = command['async'] and ' (A)' or ''
+ asyncmethod = command['async'] and ' (A)' or ''
Review comment:
@DaanHoogland shouldn't the header of this python file be changed from `#!/cygdrive/c/Python27` to `#!/cygdrive/c/Python3`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #4030: some minor changes to make the build run with python 3
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #4030:
URL: https://github.com/apache/cloudstack/pull/4030
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4030: some minor changes to make the build run with python 3
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #4030:
URL: https://github.com/apache/cloudstack/pull/4030#discussion_r466194209
##########
File path: tools/apidoc/gen_toc.py
##########
@@ -245,10 +245,10 @@ def choose_category(fn):
def xml_for(command):
name = command['name']
- async = command['async'] and ' (A)' or ''
+ asyncmethod = command['async'] and ' (A)' or ''
Review comment:
I think the cygwin specific python is not a good idea in any case `#! /bin/env python` would be better.
I think this is being taken into account in ther PRs so maybe i should close, @nvazquez @GabrielBrascher ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4030: some minor changes to make the build run with python 3
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4030:
URL: https://github.com/apache/cloudstack/pull/4030#issuecomment-729881729
The changes here are in #4479 as well, will probably close this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4030: some minor changes to make the build run with python 3
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #4030:
URL: https://github.com/apache/cloudstack/pull/4030#discussion_r465753170
##########
File path: tools/apidoc/gen_toc.py
##########
@@ -245,10 +245,10 @@ def choose_category(fn):
def xml_for(command):
name = command['name']
- async = command['async'] and ' (A)' or ''
+ asyncmethod = command['async'] and ' (A)' or ''
Review comment:
Sorry if this comment is redundant, I see that @nvazquez mentioned about changing other pieces as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #4030: some minor changes to make the build run with python 3
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #4030:
URL: https://github.com/apache/cloudstack/pull/4030
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org