You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bert Huijben <B....@competence.biz> on 2008/05/15 15:55:17 UTC
[Patch] Fix description of repos-test
[[
Updated description of repos-test to fix running this test on Windows
Vista.
* build.conf
(repos-test): Remove the magic word 'update' from the description to
allow
running the test as non-administrator on Windows Vista.
Patch by: Bert Huijben <b....@competence.biz>
]]
Vista checks the file description for specific keywords (as 'update') to
determine if a file might be a installer and in that case prompts the
user for administrative privileges.
(The recommended way to fix this behavior is adding a xml manifest to
the executable but that would require extensive changes to the build
scripts.. This change is just to stop Vista from being stupid)
Bert
Re: [Patch] Fix description of repos-test
Posted by David Glasser <gl...@davidglasser.net>.
On Fri, May 16, 2008 at 9:18 AM, Stefan Sperling <st...@elego.de> wrote:
> On Fri, May 16, 2008 at 09:12:55AM -0700, David Glasser wrote:
>> So, um, what files do we need to avoid the word "update" in? This
>> isn't even an executable file, no?
>
> 'repos-test' is the executable being built, if I understood correctly.
Oh, hmm, does the "description" field get copied into the source somewhere?
--dave
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Patch] Fix description of repos-test
Posted by Stefan Sperling <st...@elego.de>.
On Fri, May 16, 2008 at 09:12:55AM -0700, David Glasser wrote:
> So, um, what files do we need to avoid the word "update" in? This
> isn't even an executable file, no?
'repos-test' is the executable being built, if I understood correctly.
Stefan
> 2008/5/15 Bert Huijben <B....@competence.biz>:
> > [[
> > Updated description of repos-test to fix running this test on Windows
> > Vista.
> >
> > * build.conf
> > (repos-test): Remove the magic word 'update' from the description to
^^^^^^^^^^^^^
> > allow
> > running the test as non-administrator on Windows Vista.
> >
> > Patch by: Bert Huijben <b....@competence.biz>
> > ]]
> >
RE: [Patch] Fix description of repos-test
Posted by Daniel Shahaf <d....@daniel.shahaf.co.il>.
Bert Huijben wrote on Fri, 16 May 2008 at 19:19 +0200:
> For now I fixed the issue by removing the reference to svn_repos_update()
> (which doesn't even exist (anymore?)) from the description. It's not
> something that would happen by accident on a user system.
It doesn't exist, then this discussion is moot...
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
RE: [Patch] Fix description of repos-test
Posted by Bert Huijben <be...@vmoo.com>.
> -----Original Message-----
> From: Daniel Shahaf [mailto:d.s@daniel.shahaf.co.il]
> Sent: vrijdag 16 mei 2008 18:43
> To: Bert Huijben
> Cc: David Glasser; dev@subversion.tigris.org
> Subject: RE: [Patch] Fix description of repos-test
>
> Bert Huijben wrote on Fri, 16 May 2008 at 18:19 +0200:
> > > -----Original Message-----
> > > From: dglasser@gmail.com [mailto:dglasser@gmail.com] On Behalf Of
> > David
> > > Glasser
> > > Sent: vrijdag 16 mei 2008 18:13
> > > To: Bert Huijben
> > > Cc: dev@subversion.tigris.org
> > > Subject: Re: [Patch] Fix description of repos-test
> > >
> > > So, um, what files do we need to avoid the word "update" in? This
> > > isn't even an executable file, no?
> >
> > This is the only file which has the word update in it's description..
> >
> > Some of the scripting for the Windows build places this text
> literally
> > in the version resource in the .exe. (Which is a resource record
> added
> > to the file containing a few strings and file and product version
> > numbers).
> >
>
> Can we disable this scripting in Vista?
We could; but I don't think that is the right way to fix it.
(We currently have one build for all windows versions for five different
Visual Studio/C++ versions*. Extending the number of windows versions would
give us at least 5 times more test targets)
For now I fixed the issue by removing the reference to svn_repos_update()
(which doesn't even exist (anymore?)) from the description. It's not
something that would happen by accident on a user system.
Bert
* Visual C++ 6.0 (released in 1998), Visual Studio 2002, 2003, 2005 and
2008. The last two for 32 and 64 bit windows applications.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
RE: [Patch] Fix description of repos-test
Posted by Daniel Shahaf <d....@daniel.shahaf.co.il>.
Bert Huijben wrote on Fri, 16 May 2008 at 18:19 +0200:
> > -----Original Message-----
> > From: dglasser@gmail.com [mailto:dglasser@gmail.com] On Behalf Of
> David
> > Glasser
> > Sent: vrijdag 16 mei 2008 18:13
> > To: Bert Huijben
> > Cc: dev@subversion.tigris.org
> > Subject: Re: [Patch] Fix description of repos-test
> >
> > So, um, what files do we need to avoid the word "update" in? This
> > isn't even an executable file, no?
>
> This is the only file which has the word update in it's description..
>
> Some of the scripting for the Windows build places this text literally
> in the version resource in the .exe. (Which is a resource record added
> to the file containing a few strings and file and product version
> numbers).
>
Can we disable this scripting in Vista?
> And Windows looks only in the version resources of executables (not the
> code, the strings or anything).
> (The support for adding the description to the version resources was
> added in r5878)
>
>
> So the answer to your question is: In the description lines of programs
> in the build.conf file
>
> ;-)
>
> Bert
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
RE: [Patch] Fix description of repos-test
Posted by Bert Huijben <B....@competence.biz>.
> -----Original Message-----
> From: dglasser@gmail.com [mailto:dglasser@gmail.com] On Behalf Of
David
> Glasser
> Sent: vrijdag 16 mei 2008 18:13
> To: Bert Huijben
> Cc: dev@subversion.tigris.org
> Subject: Re: [Patch] Fix description of repos-test
>
> So, um, what files do we need to avoid the word "update" in? This
> isn't even an executable file, no?
This is the only file which has the word update in it's description..
Some of the scripting for the Windows build places this text literally
in the version resource in the .exe. (Which is a resource record added
to the file containing a few strings and file and product version
numbers).
And Windows looks only in the version resources of executables (not the
code, the strings or anything).
(The support for adding the description to the version resources was
added in r5878)
So the answer to your question is: In the description lines of programs
in the build.conf file
;-)
Bert
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Patch] Fix description of repos-test
Posted by David Glasser <gl...@davidglasser.net>.
So, um, what files do we need to avoid the word "update" in? This
isn't even an executable file, no?
--dave
2008/5/15 Bert Huijben <B....@competence.biz>:
> [[
> Updated description of repos-test to fix running this test on Windows
> Vista.
>
> * build.conf
> (repos-test): Remove the magic word 'update' from the description to
> allow
> running the test as non-administrator on Windows Vista.
>
> Patch by: Bert Huijben <b....@competence.biz>
> ]]
>
> Vista checks the file description for specific keywords (as 'update') to
> determine if a file might be a installer and in that case prompts the
> user for administrative privileges.
>
> (The recommended way to fix this behavior is adding a xml manifest to
> the executable but that would require extensive changes to the build
> scripts.. This change is just to stop Vista from being stupid)
>
> Bert
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Patch] Fix description of repos-test
Posted by Karl Fogel <kf...@red-bean.com>.
Applied in r31203, thanks.
"Bert Huijben" <B....@competence.biz> writes:
> [[
> Updated description of repos-test to fix running this test on Windows
> Vista.
>
> * build.conf
> (repos-test): Remove the magic word 'update' from the description to
> allow
> running the test as non-administrator on Windows Vista.
>
> Patch by: Bert Huijben <b....@competence.biz>
> ]]
>
> Vista checks the file description for specific keywords (as 'update') to
> determine if a file might be a installer and in that case prompts the
> user for administrative privileges.
>
> (The recommended way to fix this behavior is adding a xml manifest to
> the executable but that would require extensive changes to the build
> scripts.. This change is just to stop Vista from being stupid)
>
> Bert
>
> Index: build.conf
> ===================================================================
> --- build.conf (revision 31160)
> +++ build.conf (working copy)
> @@ -612,7 +612,7 @@
> # Tests for libsvn_repos
>
> [repos-test]
> -description = Test svn_repos_update() is libsvn_repos
> +description = Test delta editor in libsvn_repos
> type = exe
> path = subversion/tests/libsvn_repos
> sources = repos-test.c dir-delta-editor.c
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org