You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by michaelandrepearce <gi...@git.apache.org> on 2018/10/29 09:31:21 UTC

[GitHub] activemq-artemis pull request #2400: ARTEMIS-2151 JMS Selectors Broken in so...

GitHub user michaelandrepearce opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2400

    ARTEMIS-2151 JMS Selectors Broken in some cases

    Create Test Case
    Fix OpenWire so selectors are translated
    Fix GroupID to call groupId method

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelandrepearce/activemq-artemis ARTEMIS-2151

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2400.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2400
    
----
commit 9f2e781b87351a6e9d139171a8a3387ebb539a43
Author: Michael André Pearce <mi...@...>
Date:   2018-10-29T05:46:55Z

    ARTEMIS-2151 JMS Selectors Broken in some cases
    
    Create Test Case
    Fix OpenWire so selectors are translated
    Fix GroupID to call groupId method

----


---

[GitHub] activemq-artemis issue #2400: ARTEMIS-2151 JMS Selectors broken in some case...

Posted by clebertsuconic <gi...@git.apache.org>.

Github user clebertsuconic commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2400
  
    The some cases you mention is just AMQGroupID?
    
    If that's the case can you rename the JIRA and commit here? something like AMQGroupID is ignored on filter?
    
    
    Or am I misunderstanding what you changed here?


---

[GitHub] activemq-artemis issue #2400: ARTEMIS-2151 JMS Selectors Broken in some case...

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2400
  
    @clebertsuconic can this goto HF branch also?


---

[GitHub] activemq-artemis pull request #2400: ARTEMIS-2151 JMS Selectors broken in so...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/2400


---

[GitHub] activemq-artemis issue #2400: ARTEMIS-2151 JMS Selectors broken in some case...

Posted by michaelandrepearce <gi...@git.apache.org>.

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/2400
  
    For openwire JMSPriority, JMSCorrelationID etc etc were all broken.


---