You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/11/18 01:20:00 UTC

[GitHub] [kafka] hachikuji commented on a change in pull request #11511: MINOR: Brokers in KRaft don't need controller listener

hachikuji commented on a change in pull request #11511:
URL: https://github.com/apache/kafka/pull/11511#discussion_r751809367



##########
File path: core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala
##########
@@ -84,14 +84,6 @@ abstract class IntegrationTestHarness extends KafkaServerTestHarness {
   private def insertControllerListenersIfNeeded(props: Seq[Properties]): Unit = {
     if (isKRaftTest()) {
       props.foreach { config =>
-        // Add the CONTROLLER listener to "listeners" if it is not already there.

Review comment:
       Do we still need this method if we are no longer inserting controller listeners? Maybe we could rename it if the security config below is still needed?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org