You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/10/11 01:43:54 UTC

[GitHub] [thrift] fishy opened a new pull request #2258: THRIFT-5294: Fix panic in go TSimpleJSONProtocol

fishy opened a new pull request #2258:
URL: https://github.com/apache/thrift/pull/2258


   Client: go
   
   In go library's TSimpleJSONProtocol and TJSONProtocol implementations,
   we use slices as stacks for context info, but didn't do proper boundary
   check when peeking/popping, result in it might panic with using -1 as
   slice index in certain cases of calling Write*End without matching
   Write*Begin before.
   
   Refactor the code to properly implement the stack, and return a
   TProtocolException instead on those cases.
   
   Also add unit tests for them.
   
   <!-- Explain the changes in the pull request below: -->
     
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] fishy merged pull request #2258: THRIFT-5294: Fix panic in go TSimpleJSONProtocol

Posted by GitBox <gi...@apache.org>.
fishy merged pull request #2258:
URL: https://github.com/apache/thrift/pull/2258


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org