You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2012/10/22 05:46:13 UTC
[jira] [Created] (LUCENE-4496) Don't decode unnecessary freq blocks
in 4.1 codec
Robert Muir created LUCENE-4496:
-----------------------------------
Summary: Don't decode unnecessary freq blocks in 4.1 codec
Key: LUCENE-4496
URL: https://issues.apache.org/jira/browse/LUCENE-4496
Project: Lucene - Core
Issue Type: Improvement
Components: core/codecs
Affects Versions: 4.1
Reporter: Robert Muir
TermsEnum.docs() has an expert flag to specify you don't require frequencies. This is currently set by some things that don't need it: we should call ForUtil.skipBlock instead of ForUtil.readBlock in this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4496) Don't decode unnecessary freq
blocks in 4.1 codec
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481299#comment-13481299 ]
Michael McCandless commented on LUCENE-4496:
--------------------------------------------
+1
> Don't decode unnecessary freq blocks in 4.1 codec
> -------------------------------------------------
>
> Key: LUCENE-4496
> URL: https://issues.apache.org/jira/browse/LUCENE-4496
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/codecs
> Affects Versions: 4.1
> Reporter: Robert Muir
> Attachments: LUCENE-4496.patch, LUCENE-4496.patch
>
>
> TermsEnum.docs() has an expert flag to specify you don't require frequencies. This is currently set by some things that don't need it: we should call ForUtil.skipBlock instead of ForUtil.readBlock in this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4496) Don't decode unnecessary freq blocks
in 4.1 codec
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-4496:
--------------------------------
Attachment: LUCENE-4496.patch
Same patch, adding a few comments and beefing up TestBlockPostingsFormat3 to also check the freqs case.
I'll commit this shortly after running some more tests, and I think I want to now yank TestBlockPostingsFormat3 out of this package and let it run with any codec, it just tests these various "subset" cases and isnt specific to this PF.
> Don't decode unnecessary freq blocks in 4.1 codec
> -------------------------------------------------
>
> Key: LUCENE-4496
> URL: https://issues.apache.org/jira/browse/LUCENE-4496
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/codecs
> Affects Versions: 4.1
> Reporter: Robert Muir
> Attachments: LUCENE-4496.patch, LUCENE-4496.patch, LUCENE-4496.patch
>
>
> TermsEnum.docs() has an expert flag to specify you don't require frequencies. This is currently set by some things that don't need it: we should call ForUtil.skipBlock instead of ForUtil.readBlock in this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4496) Don't decode unnecessary freq blocks
in 4.1 codec
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-4496:
--------------------------------
Attachment: LUCENE-4496.patch
same trick for .pay blocks when they arent needed.
> Don't decode unnecessary freq blocks in 4.1 codec
> -------------------------------------------------
>
> Key: LUCENE-4496
> URL: https://issues.apache.org/jira/browse/LUCENE-4496
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/codecs
> Affects Versions: 4.1
> Reporter: Robert Muir
> Attachments: LUCENE-4496.patch, LUCENE-4496.patch
>
>
> TermsEnum.docs() has an expert flag to specify you don't require frequencies. This is currently set by some things that don't need it: we should call ForUtil.skipBlock instead of ForUtil.readBlock in this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4496) Don't decode unnecessary freq
blocks in 4.1 codec
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481437#comment-13481437 ]
Robert Muir commented on LUCENE-4496:
-------------------------------------
I committed to trunk... will give it some time in jenkins before backporting.
> Don't decode unnecessary freq blocks in 4.1 codec
> -------------------------------------------------
>
> Key: LUCENE-4496
> URL: https://issues.apache.org/jira/browse/LUCENE-4496
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/codecs
> Affects Versions: 4.1
> Reporter: Robert Muir
> Attachments: LUCENE-4496.patch, LUCENE-4496.patch, LUCENE-4496.patch
>
>
> TermsEnum.docs() has an expert flag to specify you don't require frequencies. This is currently set by some things that don't need it: we should call ForUtil.skipBlock instead of ForUtil.readBlock in this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4496) Don't decode unnecessary freq blocks
in 4.1 codec
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-4496:
--------------------------------
Attachment: LUCENE-4496.patch
All tests pass, not sure I trust they really test this case well or even how much it helps, but its a simple fix.
> Don't decode unnecessary freq blocks in 4.1 codec
> -------------------------------------------------
>
> Key: LUCENE-4496
> URL: https://issues.apache.org/jira/browse/LUCENE-4496
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/codecs
> Affects Versions: 4.1
> Reporter: Robert Muir
> Attachments: LUCENE-4496.patch
>
>
> TermsEnum.docs() has an expert flag to specify you don't require frequencies. This is currently set by some things that don't need it: we should call ForUtil.skipBlock instead of ForUtil.readBlock in this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-4496) Don't decode unnecessary freq
blocks in 4.1 codec
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-4496.
---------------------------------
Resolution: Fixed
Fix Version/s: 5.0
4.1
> Don't decode unnecessary freq blocks in 4.1 codec
> -------------------------------------------------
>
> Key: LUCENE-4496
> URL: https://issues.apache.org/jira/browse/LUCENE-4496
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/codecs
> Affects Versions: 4.1
> Reporter: Robert Muir
> Fix For: 4.1, 5.0
>
> Attachments: LUCENE-4496.patch, LUCENE-4496.patch, LUCENE-4496.patch
>
>
> TermsEnum.docs() has an expert flag to specify you don't require frequencies. This is currently set by some things that don't need it: we should call ForUtil.skipBlock instead of ForUtil.readBlock in this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org