You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "FSchumacher (via GitHub)" <gi...@apache.org> on 2023/07/21 15:33:11 UTC

[GitHub] [tomcat] FSchumacher opened a new pull request, #640: Catch NamingException instead of specialized sub-classes

FSchumacher opened a new pull request, #640:
URL: https://github.com/apache/tomcat/pull/640

   In Java 8 and up to 17 a closed connection is signaled with a NamingException and not a CommunicationException ora ServiceUnavailableException.  Such a condition should lead to re-opening the LDAP connection.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat] michael-o commented on pull request #640: Catch NamingException instead of specialized sub-classes

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #640:
URL: https://github.com/apache/tomcat/pull/640#issuecomment-1669294674

   FTR: This is my workaround approach to this:
   https://github.com/michael-o/tomcatspnegoad/blob/a22c3a4b0f7bc6592d4fd53268137599d84e6bf5/tomcat90/src/main/java/net/sf/michaelo/tomcat/realm/ActiveDirectoryRealm.java#L433-L457


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat] michael-o commented on pull request #640: Catch NamingException instead of specialized sub-classes

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #640:
URL: https://github.com/apache/tomcat/pull/640#issuecomment-1646537415

   > > You should add the JBS ID. AFAIR, I have reported that back then.
   > 
   > What is a JBS ID? Where did you report it when? The only two IDs I can think of are the old report in our bugzilla 61313 and maybe 65411, where the stacktraces show, that we get NamingExceptions, when LDAP has network problems. But on both bug entries you are missing, so I assume you mean something different. Another reference I can find, would be https://bugs.openjdk.org/browse/JDK-8273402
   
   Yes, that's the one I have reported to JBS.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat] rmaucher commented on pull request #640: Catch NamingException instead of specialized sub-classes

Posted by "rmaucher (via GitHub)" <gi...@apache.org>.
rmaucher commented on PR #640:
URL: https://github.com/apache/tomcat/pull/640#issuecomment-1646648446

   Ok, so that was a useful bug report then :) Perfect (although no backport unfortunately).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat] FSchumacher merged pull request #640: Catch NamingException instead of specialized sub-classes

Posted by "FSchumacher (via GitHub)" <gi...@apache.org>.
FSchumacher merged PR #640:
URL: https://github.com/apache/tomcat/pull/640


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat] rmaucher commented on pull request #640: Catch NamingException instead of specialized sub-classes

Posted by "rmaucher (via GitHub)" <gi...@apache.org>.
rmaucher commented on PR #640:
URL: https://github.com/apache/tomcat/pull/640#issuecomment-1646185214

   +1 for the change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat] FSchumacher commented on pull request #640: Catch NamingException instead of specialized sub-classes

Posted by "FSchumacher (via GitHub)" <gi...@apache.org>.
FSchumacher commented on PR #640:
URL: https://github.com/apache/tomcat/pull/640#issuecomment-1646534435

   > You should add the JBS ID. AFAIR, I have reported that back then.
   
   What is a JBS ID? Where did you report it when?
   The only two IDs I can think of are the old report in our bugzilla 61313 and maybe 65411, where the stacktraces show, that we get NamingExceptions, when LDAP has network problems. But on both bug entries you are missing, so I assume you mean something different.
   Another reference I can find, would be https://bugs.openjdk.org/browse/JDK-8273402


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[GitHub] [tomcat] FSchumacher commented on pull request #640: Catch NamingException instead of specialized sub-classes

Posted by "FSchumacher (via GitHub)" <gi...@apache.org>.
FSchumacher commented on PR #640:
URL: https://github.com/apache/tomcat/pull/640#issuecomment-1651850085

   > @FSchumacher, do you intend to backport it to 8.5 and 9.0?
   
   Yes, I will do that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org