You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2015/03/03 15:40:59 UTC
[GitHub] spark pull request: SPARK-1911 [DOCS] Warn users if their assembly...
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/4874
SPARK-1911 [DOCS] Warn users if their assembly jars are not built with Java 6
Add warning about building with Java 7+ and running the JAR on early Java 6.
CC @andrewor14
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srowen/spark SPARK-1911
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4874.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4874
----
commit 79fa2f6140191a1a657e1ba22a6323c08e258339
Author: Sean Owen <so...@cloudera.com>
Date: 2015-03-03T14:37:13Z
Add warning about building with Java 7+ and running the JAR on early Java 6.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-1911 [DOCS] Warn users if their assembly...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4874
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-1911 [DOCS] Warn users if their assembly...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4874#discussion_r25715262
--- Diff: docs/building-spark.md ---
@@ -9,6 +9,10 @@ redirect_from: "building-with-maven.html"
Building Spark using Maven requires Maven 3.0.4 or newer and Java 6+.
+**Note:** Building Spark with Java 7 or later can create JAR files that may not be
--- End diff --
The "or later" part is not true, I think. I remember testing that JDK7 is the problem: jars with > 65k files created on JDK7 won't work on either JDK6 *or* JDK8 (!). Jars created with anything but JDK7 seem to work everywhere.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-1911 [DOCS] Warn users if their assembly...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4874#issuecomment-76973717
[Test build #28233 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28233/consoleFull) for PR 4874 at commit [`79fa2f6`](https://github.com/apache/spark/commit/79fa2f6140191a1a657e1ba22a6323c08e258339).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-1911 [DOCS] Warn users if their assembly...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4874#issuecomment-76973737
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28233/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-1911 [DOCS] Warn users if their assembly...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/4874#issuecomment-77041640
Yeah, LGTM I'm surprised this is not already documented. Merging into master and 1.3. There were some conflicts to merge this into older branches, so feel free to open this PR against those branches.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-1911 [DOCS] Warn users if their assembly...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4874#discussion_r25727437
--- Diff: docs/building-spark.md ---
@@ -9,6 +9,10 @@ redirect_from: "building-with-maven.html"
Building Spark using Maven requires Maven 3.0.4 or newer and Java 6+.
+**Note:** Building Spark with Java 7 or later can create JAR files that may not be
--- End diff --
Nevermind me. Just ran some quick tests and it seems your warning is accurate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: SPARK-1911 [DOCS] Warn users if their assembly...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4874#issuecomment-76957508
[Test build #28233 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28233/consoleFull) for PR 4874 at commit [`79fa2f6`](https://github.com/apache/spark/commit/79fa2f6140191a1a657e1ba22a6323c08e258339).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org