You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/31 10:37:32 UTC

[GitHub] [doris] ccoffline opened a new pull request, #13832: [Bug] Fix prometheus read format error #13831

ccoffline opened a new pull request, #13832:
URL: https://github.com/apache/doris/pull/13832

   # Proposed changes
   
   Issue Number: close #13831
   
   ## Problem summary
   
   fix prometheus format error
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] spaces-X commented on pull request #13832: [Bug] Fix prometheus read format error #13831

Posted by GitBox <gi...@apache.org>.
spaces-X commented on PR #13832:
URL: https://github.com/apache/doris/pull/13832#issuecomment-1313736264

   To compatible with the metric grouped by the database name.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #13832: [Bug] Fix prometheus read format error #13831

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13832:
URL: https://github.com/apache/doris/pull/13832#issuecomment-1313662569

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 34.25 seconds
    load time: 432 seconds
    storage size: 17171500889 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221114130322_clickbench_pr_45677.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] morningman merged pull request #13832: [Bug] Fix prometheus read format error #13831

Posted by GitBox <gi...@apache.org>.
morningman merged PR #13832:
URL: https://github.com/apache/doris/pull/13832


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] spaces-X commented on pull request #13832: [Bug] Fix prometheus read format error #13831

Posted by GitBox <gi...@apache.org>.
spaces-X commented on PR #13832:
URL: https://github.com/apache/doris/pull/13832#issuecomment-1313734492

   used to compatible with the metric group by db.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] stalary commented on pull request #13832: [Bug] Fix prometheus read format error #13831

Posted by GitBox <gi...@apache.org>.
stalary commented on PR #13832:
URL: https://github.com/apache/doris/pull/13832#issuecomment-1297884774

   Can you add some test?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] spaces-X commented on a diff in pull request #13832: [Bug] Fix prometheus read format error #13831

Posted by GitBox <gi...@apache.org>.
spaces-X commented on code in PR #13832:
URL: https://github.com/apache/doris/pull/13832#discussion_r1021565042


##########
fe/fe-core/src/main/java/org/apache/doris/metric/MetricRepo.java:
##########
@@ -57,7 +57,7 @@ public final class MetricRepo {
     private static final Logger LOG = LogManager.getLogger(MetricRepo.class);
 
     // METRIC_REGISTER is only used for histogram metrics
-    private static final MetricRegistry METRIC_REGISTER = new MetricRegistry();
+    public static final MetricRegistry METRIC_REGISTER = new MetricRegistry();

Review Comment:
   for UT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] ccoffline commented on pull request #13832: [Bug] Fix prometheus read format error #13831

Posted by GitBox <gi...@apache.org>.
ccoffline commented on PR #13832:
URL: https://github.com/apache/doris/pull/13832#issuecomment-1298015992

   > Can you add some test?
   
   This bug is found because prometheus reports an error. So the only way to test this is to deploy Doris and let Prometheus tell us if the metrics api has an error.
   I'll try to add some unit tests though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] ccoffline commented on pull request #13832: [Bug] Fix prometheus read format error #13831

Posted by GitBox <gi...@apache.org>.
ccoffline commented on PR #13832:
URL: https://github.com/apache/doris/pull/13832#issuecomment-1313349907

   > Can you add some test?
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org