You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/11/06 12:54:57 UTC
Review Request 71732: Fixed an incorrect resource mutation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71732/
-----------------------------------------------------------
Review request for mesos, Benno Evers and Greg Mann.
Repository: mesos
Description
-------
`Resources::pushReservation` does not mutate the `Resources` it is
invoked on; instead it returns its result which should then be used.
This issue was identified by making `Resources::pushReservation`
`nodiscard`.
Diffs
-----
src/tests/scheduler_tests.cpp e0ed02900330c678bbf5c609c1f45d05147851ed
Diff: https://reviews.apache.org/r/71732/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 71732: Fixed an incorrect resource mutation.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71732/#review218663
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On Nov. 6, 2019, 12:54 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71732/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2019, 12:54 p.m.)
>
>
> Review request for mesos, Benno Evers and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `Resources::pushReservation` does not mutate the `Resources` it is
> invoked on; instead it returns its result which should then be used.
>
> This issue was identified by making `Resources::pushReservation`
> `nodiscard`.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp e0ed02900330c678bbf5c609c1f45d05147851ed
>
>
> Diff: https://reviews.apache.org/r/71732/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71732: Fixed an incorrect resource mutation.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71732/#review218543
-----------------------------------------------------------
Patch looks great!
Reviews applied: [71732]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Nov. 6, 2019, 12:54 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71732/
> -----------------------------------------------------------
>
> (Updated Nov. 6, 2019, 12:54 p.m.)
>
>
> Review request for mesos, Benno Evers and Greg Mann.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `Resources::pushReservation` does not mutate the `Resources` it is
> invoked on; instead it returns its result which should then be used.
>
> This issue was identified by making `Resources::pushReservation`
> `nodiscard`.
>
>
> Diffs
> -----
>
> src/tests/scheduler_tests.cpp e0ed02900330c678bbf5c609c1f45d05147851ed
>
>
> Diff: https://reviews.apache.org/r/71732/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>