[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #188: Split parquet file scan tasks at row group boundaries

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #188: Split parquet file scan tasks at row group boundaries
URL: https://github.com/apache/incubator-iceberg/pull/188#discussion_r285219034
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/DataFile.java
 ##########
 @@ -139,8 +139,10 @@ static StructType getType(StructType partitionType) {
   DataFile copy();
 
   /**
-   * @return a list of offsets for file blocks if applicable, null otherwise. When available, this
-   * information is used for planning scan tasks whose boundaries are determined by these offsets.
+   * @return List of offsets for blocks of a file, if applicable, null otherwise.
+   * When available, this information is used for planning scan tasks whose boundaries
+   * are determined by these offsets.It is important that the returned list is sorted
 
 Review comment:
   Nit: missing a space.
   
   I think we should phrase the new content a little differently. "It is important" isn't very clear. I think it should be "offsets *must* be in sorted order."

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org