You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "dcapwell (via GitHub)" <gi...@apache.org> on 2024/05/03 23:27:52 UTC
[PR] Cassandra 19618 [cassandra]
dcapwell opened a new pull request, #3293:
URL: https://github.com/apache/cassandra/pull/3293
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19618 [cassandra]
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #3293:
URL: https://github.com/apache/cassandra/pull/3293#discussion_r1594309985
##########
src/java/org/apache/cassandra/config/AccordSpec.java:
##########
@@ -71,4 +73,62 @@ public enum TransactionalRangeMigration
public TransactionalMode default_transactional_mode = TransactionalMode.off;
public boolean ephemeralReadEnabled = false;
public boolean state_cache_listener_jfr_enabled = true;
+ public final JournalSpec journal = new JournalSpec();
+
+ public static class JournalSpec implements Params
+ {
+ public int segmentSize = 32 << 20;
Review Comment:
we don't actually need to have our variables as `segment_size` as the yaml layer converts camel case to the expected naming... this is *only* `segment_size` in yaml, same for every field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19618 [cassandra]
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on code in PR #3293:
URL: https://github.com/apache/cassandra/pull/3293#discussion_r1594310904
##########
src/java/org/apache/cassandra/config/AccordSpec.java:
##########
@@ -71,4 +73,62 @@ public enum TransactionalRangeMigration
public TransactionalMode default_transactional_mode = TransactionalMode.off;
public boolean ephemeralReadEnabled = false;
public boolean state_cache_listener_jfr_enabled = true;
+ public final JournalSpec journal = new JournalSpec();
+
+ public static class JournalSpec implements Params
+ {
+ public int segmentSize = 32 << 20;
+ public FailurePolicy failurePolicy = FailurePolicy.STOP;
+ public FlushMode flushMode = FlushMode.BATCH;
+ public DurationSpec.IntMillisecondsBound flushPeriod; // pulls default from 'commitlog_sync_period'
+ public DurationSpec.IntMillisecondsBound periodicFlushLagBlock = new DurationSpec.IntMillisecondsBound("1500ms");
+
+ @Override
+ public int segmentSize()
+ {
+ return segmentSize;
+ }
+
+ @Override
+ public FailurePolicy failurePolicy()
+ {
+ return failurePolicy;
+ }
+
+ @Override
+ public FlushMode flushMode()
+ {
+ return flushMode;
+ }
+
+ @JsonIgnore
+ @Override
+ public int flushPeriodMillis()
+ {
+ return flushPeriod == null ? DatabaseDescriptor.getCommitLogSyncPeriod()
+ : flushPeriod.toMilliseconds();
+ }
+
+ @JsonIgnore
Review Comment:
I think this isn't needed as `get` is needed for it to be picked up... I was just trying to be explicit...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19618 [cassandra]
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell commented on PR #3293:
URL: https://github.com/apache/cassandra/pull/3293#issuecomment-2113043380
merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Cassandra 19618 [cassandra]
Posted by "dcapwell (via GitHub)" <gi...@apache.org>.
dcapwell closed pull request #3293: Cassandra 19618
URL: https://github.com/apache/cassandra/pull/3293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org