You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/12/01 20:27:48 UTC
[GitHub] [sling-org-apache-sling-models-validation-impl] stefanseifert opened a new pull request #1: SLING-10960 switch to OSGI R7 annotations and update to sling-bundle-parent 46
stefanseifert opened a new pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1
also update integration tests to Sling 11 to ensure they can be run with Java 8 and Java 11
@kwin the integration tests do not run successfully - i do not fully understand the reason. the testing bundle is deployed and the initial content contained in it is installed, but then the validation impl throws warnings like
```
01.12.2021 21:26:09.574 *WARN* [EventAdminThread #2] org.apache.sling.validation.impl.resourcemodel.ResourceValidationModelProviderImpl Could not get covered resource type of newly added validation model at /apps/sling/validation/models/model1
java.lang.IllegalStateException: Can no longer access resource at /apps/sling/validation/models/model1
at org.apache.sling.validation.impl.resourcemodel.ResourceValidationModelProviderImpl.getResourceTypeOfValidationModel(ResourceValidationModelProviderImpl.java:199) [org.apache.sling.validation.core:1.0.4]
at org.apache.sling.validation.impl.resourcemodel.ResourceValidationModelProviderImpl.handleEvent(ResourceValidationModelProviderImpl.java:163) [org.apache.sling.validation.core:1.0.4]
at org.apache.felix.eventadmin.impl.handler.EventHandlerProxy.sendEvent(EventHandlerProxy.java:415)
at org.apache.felix.eventadmin.impl.tasks.HandlerTask.run(HandlerTask.java:70) [org.apache.felix.eventadmin:1.5.0]
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-models-validation-impl] kwin commented on pull request #1: SLING-10960 switch to OSGI R7 annotations and update to sling-bundle-parent 46
Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1#issuecomment-985400072
It turns out that at the time when the Sling validation model is added the service user "sling-validation" does no longer have read access to `/apps`. This seems because the jcr content loader seems to remove the ACLs on node /apps for some reason when adding the teleported bundle which contains the header `Sling-Initial-Content: SLING-CONTENT; overwrite:=true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-models-validation-impl] kwin commented on pull request #1: SLING-10960 switch to OSGI R7 annotations and update to sling-bundle-parent 46
Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1#issuecomment-985310683
This seems to be a followup error, as the `ClientSideTeleporter` retries installing the teleported bundle multiple times.
```
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Building bundle 'ClientSideTeleporter.ModelValidationIT'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Add bundle header 'Sling-Initial-Content' with value 'SLING-CONTENT;overwrite:=true'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Add bundle header 'Sling-Model-Packages' with value 'org.apache.sling.models.validation.impl.it'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/content.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/models.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/content/contentValid.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/content/contentInvalid.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/content/contentWithNoValidationModel.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/models/model1.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Persisting test bundle in '/Users/konradwindszus/git/sling/sling-org-apache-sling-models-validation-impl/target/test-bundles/ClientSideTeleporter.ModelValidationIT.jar'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Installing bundle 'ClientSideTeleporter.ModelValidationIT' to http://localhost:51547
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Uninstalling bundle 'ClientSideTeleporter.ModelValidationIT' from http://localhost:51547
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Building bundle 'ClientSideTeleporter.ModelValidationIT'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Add bundle header 'Sling-Initial-Content' with value 'SLING-CONTENT;overwrite:=true'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Add bundle header 'Sling-Model-Packages' with value 'org.apache.sling.models.validation.impl.it'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/content.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/models.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/content/contentValid.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/content/contentInvalid.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/content/contentWithNoValidationModel.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/models/model1.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Persisting test bundle in '/Users/konradwindszus/git/sling/sling-org-apache-sling-models-validation-impl/target/test-bundles/ClientSideTeleporter.ModelValidationIT.jar'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Installing bundle 'ClientSideTeleporter.ModelValidationIT' to http://localhost:51547
```
It rather seems to be an issue with https://github.com/apache/sling-org-apache-sling-junit-teleporter/blob/1677e496cf5154f63836b6f58e29d4d17c2ededa/src/main/java/org/apache/sling/testing/teleporter/client/TeleporterHttpClient.java#L178. Unfortunately the underlying exception is not properly logged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-models-validation-impl] kwin commented on pull request #1: SLING-10960 switch to OSGI R7 annotations and update to sling-bundle-parent 46
Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1#issuecomment-985412538
Done in https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1/commits/fba0152da0eab53c461612907822b8fa136bcdac. Now the ITs pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-models-validation-impl] kwin merged pull request #1: SLING-10960 switch to OSGI R7 annotations and update to sling-bundle-parent 46
Posted by GitBox <gi...@apache.org>.
kwin merged pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-models-validation-impl] kwin removed a comment on pull request #1: SLING-10960 switch to OSGI R7 annotations and update to sling-bundle-parent 46
Posted by GitBox <gi...@apache.org>.
kwin removed a comment on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1#issuecomment-985310683
This seems to be a followup error, as the `ClientSideTeleporter` retries installing the teleported bundle multiple times.
```
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Building bundle 'ClientSideTeleporter.ModelValidationIT'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Add bundle header 'Sling-Initial-Content' with value 'SLING-CONTENT;overwrite:=true'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Add bundle header 'Sling-Model-Packages' with value 'org.apache.sling.models.validation.impl.it'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/content.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/models.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/content/contentValid.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/content/contentInvalid.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/content/contentWithNoValidationModel.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/models/model1.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Persisting test bundle in '/Users/konradwindszus/git/sling/sling-org-apache-sling-models-validation-impl/target/test-bundles/ClientSideTeleporter.ModelValidationIT.jar'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Installing bundle 'ClientSideTeleporter.ModelValidationIT' to http://localhost:51547
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Uninstalling bundle 'ClientSideTeleporter.ModelValidationIT' from http://localhost:51547
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Building bundle 'ClientSideTeleporter.ModelValidationIT'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Add bundle header 'Sling-Initial-Content' with value 'SLING-CONTENT;overwrite:=true'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Add bundle header 'Sling-Model-Packages' with value 'org.apache.sling.models.validation.impl.it'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/content.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/models.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/content/contentValid.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/content/contentInvalid.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/content/contentWithNoValidationModel.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Embed resource '/SLING-CONTENT/apps/sling/validation/models/model1.json'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Persisting test bundle in '/Users/konradwindszus/git/sling/sling-org-apache-sling-models-validation-impl/target/test-bundles/ClientSideTeleporter.ModelValidationIT.jar'
[main] INFO org.apache.sling.testing.teleporter.client.ClientSideTeleporter - Installing bundle 'ClientSideTeleporter.ModelValidationIT' to http://localhost:51547
```
It rather seems to be an issue with https://github.com/apache/sling-org-apache-sling-junit-teleporter/blob/1677e496cf5154f63836b6f58e29d4d17c2ededa/src/main/java/org/apache/sling/testing/teleporter/client/TeleporterHttpClient.java#L178. Unfortunately the underlying exception is not properly logged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-models-validation-impl] stefanseifert commented on pull request #1: SLING-10960 switch to OSGI R7 annotations and update to sling-bundle-parent 46
Posted by GitBox <gi...@apache.org>.
stefanseifert commented on pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-models-validation-impl/pull/1#issuecomment-985411508
oh - good catch - probably just split up the sling-initial-content to deploy individually to /apps/xxx and thus not replacing /apps and the other root folders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org