You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by 56quarters <gi...@git.apache.org> on 2017/09/15 18:33:42 UTC
[GitHub] kafka pull request #3876: Force Connect tasks to stop via thread interruptio...
GitHub user 56quarters opened a pull request:
https://github.com/apache/kafka/pull/3876
Force Connect tasks to stop via thread interruption after a timeout
Interrupt the thread of Kafka Connect tasks that do not stop within
the timeout via `Worker::stopAndAwaitTasks()`. Previously tasks would
be asked to stop via setting a `stopping` flag. It was possible for
tasks to ignore this flag if they were, for example, waiting for
a lock or blocked on I/O.
This prevents issues where tasks may end up with multiple threads
all running and attempting to make progress when there should only
be a single thread running for that task at a time.
Fixes KAFKA-5896
/cc @rhauch @tedyu
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarter-travel-media/kafka force-task-stop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3876.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3876
----
commit 31c879c1a1f0bd4f5999c021baca8e99e733ffe1
Author: Nick Pillitteri <ni...@smartertravelmedia.com>
Date: 2017-09-13T14:54:40Z
Force Connect tasks to stop via thread interruption after a timeout
Interrupt the thread of Kafka Connect tasks that do not stop within
the timeout via Worker::stopAndAwaitTasks(). Previously tasks would
be asked to stop via setting a `stopping` flag. It was possible for
tasks to ignore this flag if they were, for example, waiting for
a lock or blocked on I/O.
This prevents issues where tasks may end up with multiple threads
all running and attempting to make progress when there should only
be a single thread running for that task at a time.
Fixes KAFKA-5896
----
---
[GitHub] kafka pull request #3876: KAFKA-5896: Force Connect tasks to stop via thread...
Posted by 56quarters <gi...@git.apache.org>.
GitHub user 56quarters reopened a pull request:
https://github.com/apache/kafka/pull/3876
KAFKA-5896: Force Connect tasks to stop via thread interruption
Interrupt the thread of Kafka Connect tasks that do not stop within
the timeout via `Worker::stopAndAwaitTasks()`. Previously tasks would
be asked to stop via setting a `stopping` flag. It was possible for
tasks to ignore this flag if they were, for example, waiting for
a lock or blocked on I/O.
This prevents issues where tasks may end up with multiple threads
all running and attempting to make progress when there should only
be a single thread running for that task at a time.
Fixes KAFKA-5896
/cc @rhauch @tedyu
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/smarter-travel-media/kafka force-task-stop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3876.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3876
----
commit 31c879c1a1f0bd4f5999c021baca8e99e733ffe1
Author: Nick Pillitteri <ni...@smartertravelmedia.com>
Date: 2017-09-13T14:54:40Z
Force Connect tasks to stop via thread interruption after a timeout
Interrupt the thread of Kafka Connect tasks that do not stop within
the timeout via Worker::stopAndAwaitTasks(). Previously tasks would
be asked to stop via setting a `stopping` flag. It was possible for
tasks to ignore this flag if they were, for example, waiting for
a lock or blocked on I/O.
This prevents issues where tasks may end up with multiple threads
all running and attempting to make progress when there should only
be a single thread running for that task at a time.
Fixes KAFKA-5896
commit ed3ef9c1f139cae4f09eefe1f66edc1c58c5ace6
Author: Nick Pillitteri <ni...@smartertravelmedia.com>
Date: 2017-09-15T19:54:15Z
Rename per CR
commit afea834c708eae2b7d3dedbdeafed83197eaed94
Author: Nick Pillitteri <ni...@tshlabs.org>
Date: 2017-09-16T04:52:57Z
Rename per CR
----
---
[GitHub] kafka pull request #3876: KAFKA-5896: Force Connect tasks to stop via thread...
Posted by 56quarters <gi...@git.apache.org>.
Github user 56quarters closed the pull request at:
https://github.com/apache/kafka/pull/3876
---