[jira] [Comment Edited] (SLING-3136) Configure -> Convert to Bundle/Content Package project should not assume the project is Maven-based

["Robert Munteanu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004553#comment-14004553 ] 

Robert Munteanu edited comment on SLING-3136 at 5/21/14 10:27 AM:
------------------------------------------------------------------

The main reason is that not having a filter.xml is a bad idea, especially for large projects/repositories as we get a lot of traffic between Eclipse and the repository. And also an arbitrary jcr_root directory may be present, not necessarily the one we're looking for. But a jcr_root alongside META-INF/vault/filter.xml is a definite sign of a content project.


was (Author: rombert):
The main reason is that not having a filter.xml is a bad idea, especially for large projects/repositories as we get a lot of traffic between Eclipse and the repository.

> Configure -> Convert to Bundle/Content Package project should not assume the project is Maven-based
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SLING-3136
>                 URL: https://issues.apache.org/jira/browse/SLING-3136
>             Project: Sling
>          Issue Type: Improvement
>          Components: IDE
>            Reporter: Robert Munteanu
>            Assignee: Robert Munteanu
>             Fix For: Sling Eclipse IDE 1.0.0
>
>
> There are a couple of issues with the way the current configuration actions are done:
> - it is only enabled for Maven projects ; this does not apply to all projects and is confusing
> - for the Content Package action, it only enables itself for projects of type 'content-package' . This should not be checked against since this packaging does not exist from a Sling point of view
> - for the Content package action, it assumes that the content sync root is src/main/content/jcr_root, even though it may not exist.
> Instead, I propose the following:
> 1. Use only the WST facets definition to decide if we can convert a project to a facet ; I guess for now we can simply disallow projects from having both facets ( content + bundle )
> 2. Do not make Maven a hard requirement
> 3. Use the following heuristic to detect the content sync root:
> - look for the following ( can be made configurable later ) directories
>   - jcr_root
>   - src/main/content/jcr_root
> Whenever such a project is found, make it the default jcr_root directory. If none is found, ask the user for input.
> More specific actions can be done as part of the m2e configurator for content packages tracked under SLING-3100 .



--
This message was sent by Atlassian JIRA
(v6.2#6252)