You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/10/23 01:43:31 UTC
[GitHub] codecov-io commented on issue #460: SCB-972 Using Sha1 signature
key as UUID of micro service
codecov-io commented on issue #460: SCB-972 Using Sha1 signature key as UUID of micro service
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/460#issuecomment-432054538
# [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/460?src=pr&el=h1) Report
> Merging [#460](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/460?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/5a54da2388860cebdeadc53d267e77b69b4fa06b?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/460?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #460 +/- ##
==========================================
- Coverage 60.18% 60.16% -0.02%
==========================================
Files 156 156
Lines 13414 13415 +1
==========================================
- Hits 8073 8071 -2
- Misses 4762 4765 +3
Partials 579 579
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/460?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/service/microservice.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/460/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvbWljcm9zZXJ2aWNlLmdv) | `71.45% <100%> (+0.05%)` | :arrow_up: |
| [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/460/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.53% <100%> (+0.19%)` | :arrow_up: |
| [pkg/etcdsync/mutex.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/460/diff?src=pr&el=tree#diff-cGtnL2V0Y2RzeW5jL211dGV4Lmdv) | `61.29% <0%> (-5.38%)` | :arrow_down: |
| [server/service/util/tag\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/460/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `61.53% <0%> (-3.85%)` | :arrow_down: |
| [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/460/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: |
| [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/460/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: |
| [pkg/util/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/460/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==) | `67.56% <0%> (+1.35%)` | :arrow_up: |
| [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/460/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `81.81% <0%> (+9.09%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/460?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/460?src=pr&el=footer). Last update [5a54da2...16e3882](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/460?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services