You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by rawkintrevo <gi...@git.apache.org> on 2015/11/19 14:12:38 UTC
[GitHub] flink pull request: Flink 1994- Add different gain calculation sch...
GitHub user rawkintrevo opened a pull request:
https://github.com/apache/flink/pull/1384
Flink 1994- Add different gain calculation schemes to SGD
Added 5 gain calculation schemes and .setOptimization method which takes an int values 0-5.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rawkintrevo/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1384.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1384
----
commit bbf452e7cac7fcafcc494c79062d5139fe49117c
Author: rawkintrevo <tr...@gmail.com>
Date: 2015-10-05T16:27:58Z
FLINK-1994: Added 3 new effective learning rates
commit 08c39f68cd30ce039131f2a1928fb7ae8125e1a2
Author: trevor <tr...@tower1.hsd1.il.comcast.net>
Date: 2015-10-31T00:28:53Z
Merge remote-tracking branch 'upstream/master'
I'm not sure what's happening...
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: Flink 1994- Add different gain calculation sch...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1384#issuecomment-158896082
Hi @rawkintrevo, thanks for your contribution.
You have some scala style violations in `GradientDescent.scala` line 46 and 168. The lines mustn't be longer than 100 characters as the maven log output indicates.
Furthermore, could you change the title to the format "[FLINK-1994] [ml] Add different gain calculation schemes to SGD". That way, the JIRA issues will be automatically updated with the what happens on Github.
In Flink, we always rebase our changes on top of the current master branch. Therefore, it would be good if you could revert the last merge commit. If you want to update on the latest master, then do a rebase and a force push to the branch in your repository (here `master`).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1994] [ml] Add different gain calculati...
Posted by rawkintrevo <gi...@git.apache.org>.
Github user rawkintrevo closed the pull request at:
https://github.com/apache/flink/pull/1384
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1994] [ml] Add different gain calculati...
Posted by rawkintrevo <gi...@git.apache.org>.
Github user rawkintrevo commented on the pull request:
https://github.com/apache/flink/pull/1384#issuecomment-159139713
did what you said ( I think ) and opened a new pull request
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---