You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by sh...@apache.org on 2017/04/28 07:03:09 UTC
[3/7] lucene-solr:feature/autoscaling: SOLR-10376: Return shallow
copy from getScheduledTriggerNames() method for safe access
SOLR-10376: Return shallow copy from getScheduledTriggerNames() method for safe access
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/8f0d8085
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/8f0d8085
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/8f0d8085
Branch: refs/heads/feature/autoscaling
Commit: 8f0d8085830cbcdb4b406a4d863862b852fc5a68
Parents: 1afa3ce
Author: Shalin Shekhar Mangar <sh...@apache.org>
Authored: Fri Apr 28 11:50:40 2017 +0530
Committer: Shalin Shekhar Mangar <sh...@apache.org>
Committed: Fri Apr 28 11:50:40 2017 +0530
----------------------------------------------------------------------
.../java/org/apache/solr/cloud/autoscaling/ScheduledTriggers.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/8f0d8085/solr/core/src/java/org/apache/solr/cloud/autoscaling/ScheduledTriggers.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/cloud/autoscaling/ScheduledTriggers.java b/solr/core/src/java/org/apache/solr/cloud/autoscaling/ScheduledTriggers.java
index 2248901..f72f396 100644
--- a/solr/core/src/java/org/apache/solr/cloud/autoscaling/ScheduledTriggers.java
+++ b/solr/core/src/java/org/apache/solr/cloud/autoscaling/ScheduledTriggers.java
@@ -22,6 +22,7 @@ import java.io.IOException;
import java.lang.invoke.MethodHandles;
import java.util.Collections;
import java.util.HashMap;
+import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
@@ -135,7 +136,7 @@ public class ScheduledTriggers implements Closeable {
* @return an unmodifiable set of names of all triggers being managed by this class
*/
public synchronized Set<String> getScheduledTriggerNames() {
- return Collections.unmodifiableSet(scheduledTriggers.keySet());
+ return Collections.unmodifiableSet(new HashSet<>(scheduledTriggers.keySet())); // shallow copy
}
@Override