You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@oozie.apache.org by Virag Kothari <vi...@yahoo-inc.com> on 2012/04/03 01:34:51 UTC

Review Request: oozie-783: Upgrade to Junit4

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4618/
-----------------------------------------------------------

Review request for oozie.


Summary
-------

Changes:
1) @Test, @After, @Before annotations added
2) extends TestCase removed
3) Imports added (Some of the imports are unused, but they can be removed together in a separate patch)
4) Junit 4 has a different way to obtain testcase method name; added in XTestCase  


This addresses bug oozie-783.
    https://issues.apache.org/jira/browse/oozie-783


Diffs
-----

  trunk/client/src/test/java/org/apache/oozie/cli/TestCLIParser.java 1308607 
  trunk/client/src/test/java/org/apache/oozie/cli/TestValidation.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/TestActionBean.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/TestDagELFunctions.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/TestWorkflowBean.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/TestActionExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/decision/TestDecisionActionExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/ShellTestCase.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestRerun.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutorAsExtension.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/client/TestLocalOozie.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClientException.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowXClient.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorAction.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorJob.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowAction.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowJob.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/TestCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/TestXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobsXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordJobsXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordResumeXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSuspendXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestLastModified.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitPigXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsCountForJobGetJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsDeleteForPurgeJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobDeleteJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsActiveCountJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteForPurgeJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseCountGetJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobDeleteJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsRunningJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsStatusByPendingFalseJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSuspendedJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetPendingActionsCountJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetRunningActionsCountJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobUpdateJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsToBeMaterializedJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionDeleteJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionRetryManualGetJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionSubsetGetJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionUpdateJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsDeleteForPurgeJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsGetForJobJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowInfoWithActionsSubsetGetJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobDeleteJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetActionsJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobUpdateJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestActionService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestCallbackService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestConfigurationService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestDagXLogInfoService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestELService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestGroupsService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestJPAService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestMemoryLocksService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestPauseTransitService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestProxyUserService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestSchedulerService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestSchemaService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestStoreService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestUUIDService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/service/TestXLogService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/servlet/MyJsonRestServlet.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestCallbackServlet.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestHostnameFilter.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestJobsServlet.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestJsonRestServlet.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestV0JobServlet.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/store/TestSLAStore.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/test/TestEmbeddedServletContainer.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/test/TestXFsTestCase.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/test/TestXTestCase.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/TestELConstantsFunctions.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/TestIOUtils.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/TestInstrumentation.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/TestMemoryLocks.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/TestParamChecker.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/TestPriorityDelayQueue.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/TestWritableUtils.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/TestXConfiguration.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/TestXLog.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/TestXLogReader.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/TestXmlUtils.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/db/TestSchema.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java 1308607 
  trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowLib.java 1308607 
  trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 1308607 
  trunk/pom.xml 1308607 

Diff: https://reviews.apache.org/r/4618/diff


Testing
-------

Ran bin/mkdistro


Thanks,

Virag

Re: Review Request: oozie-783: Upgrade to Junit4

Posted by Virag Kothari <vi...@yahoo-inc.com>.


> On 2012-04-03 17:42:10, Alejandro Abdelnur wrote:
> > In hadoop-land what they've done was upgrading to junit4 and leaving all existing tests as is as junit4 is 100% backwards compat with junit3. 
> > 
> > What is your take on this approach? (I'm not against  this PATCH, just asking to see if that would make sense or not)

The only reason for upgrading the existing test cases to Junit4 is to enable the testcase methods to run in parallel and reduce the running time. With Junit3, we can configure surefire to run test classes in parallel, but running testcase methods in parallel is not possible.


- Virag


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4618/#review6655
-----------------------------------------------------------


On 2012-04-02 23:34:51, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4618/
> -----------------------------------------------------------
> 
> (Updated 2012-04-02 23:34:51)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> Changes:
> 1) @Test, @After, @Before annotations added
> 2) extends TestCase removed
> 3) Imports added (Some of the imports are unused, but they can be removed together in a separate patch)
> 4) Junit 4 has a different way to obtain testcase method name; added in XTestCase  
> 
> 
> This addresses bug oozie-783.
>     https://issues.apache.org/jira/browse/oozie-783
> 
> 
> Diffs
> -----
> 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestCLIParser.java 1308607 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestValidation.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/TestActionBean.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/TestDagELFunctions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/TestWorkflowBean.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/decision/TestDecisionActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ShellTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestRerun.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutorAsExtension.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/TestLocalOozie.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClientException.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowXClient.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorAction.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorJob.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowAction.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowJob.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/TestCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/TestXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobsXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordJobsXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordResumeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSuspendXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestLastModified.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitPigXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsCountForJobGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsDeleteForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobDeleteJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsActiveCountJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseCountGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobDeleteJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsRunningJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsStatusByPendingFalseJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSuspendedJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetPendingActionsCountJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetRunningActionsCountJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobUpdateJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsToBeMaterializedJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionDeleteJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionRetryManualGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionSubsetGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionUpdateJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsDeleteForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsGetForJobJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowInfoWithActionsSubsetGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobDeleteJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetActionsJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobUpdateJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallbackService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestConfigurationService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestDagXLogInfoService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestELService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestGroupsService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestJPAService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestMemoryLocksService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPauseTransitService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestProxyUserService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchedulerService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchemaService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStoreService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestUUIDService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestXLogService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MyJsonRestServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestCallbackServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestHostnameFilter.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJobsServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJsonRestServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV0JobServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/store/TestSLAStore.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/TestEmbeddedServletContainer.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXFsTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELConstantsFunctions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestIOUtils.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestInstrumentation.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestMemoryLocks.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestParamChecker.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestPriorityDelayQueue.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestWritableUtils.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXConfiguration.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLog.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogReader.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXmlUtils.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSchema.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowLib.java 1308607 
>   trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 1308607 
>   trunk/pom.xml 1308607 
> 
> Diff: https://reviews.apache.org/r/4618/diff
> 
> 
> Testing
> -------
> 
> Ran bin/mkdistro
> 
> 
> Thanks,
> 
> Virag
> 
>

Re: Review Request: oozie-783: Upgrade to Junit4

Posted by Alejandro Abdelnur <tu...@cloudera.com>.


> On 2012-04-03 17:42:10, Alejandro Abdelnur wrote:
> > In hadoop-land what they've done was upgrading to junit4 and leaving all existing tests as is as junit4 is 100% backwards compat with junit3. 
> > 
> > What is your take on this approach? (I'm not against  this PATCH, just asking to see if that would make sense or not)
> 
> Virag Kothari wrote:
>     The only reason for upgrading the existing test cases to Junit4 is to enable the testcase methods to run in parallel and reduce the running time. With Junit3, we can configure surefire to run test classes in parallel, but running testcase methods in parallel is not possible.

got it. However you'll run into issues as several testcases set system properties using the XTestCase method setSysProperty() that are valid for the duration of the testcase. if you parallelize those tests, then you'll have a race condition. you'll have to make sure ALL those tests are run one after the other, can you do that in junit ? (I know in ngtest you can)


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4618/#review6655
-----------------------------------------------------------


On 2012-04-02 23:34:51, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4618/
> -----------------------------------------------------------
> 
> (Updated 2012-04-02 23:34:51)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> Changes:
> 1) @Test, @After, @Before annotations added
> 2) extends TestCase removed
> 3) Imports added (Some of the imports are unused, but they can be removed together in a separate patch)
> 4) Junit 4 has a different way to obtain testcase method name; added in XTestCase  
> 
> 
> This addresses bug oozie-783.
>     https://issues.apache.org/jira/browse/oozie-783
> 
> 
> Diffs
> -----
> 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestCLIParser.java 1308607 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestValidation.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/TestActionBean.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/TestDagELFunctions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/TestWorkflowBean.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/decision/TestDecisionActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ShellTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestRerun.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutorAsExtension.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/TestLocalOozie.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClientException.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowXClient.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorAction.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorJob.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowAction.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowJob.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/TestCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/TestXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobsXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordJobsXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordResumeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSuspendXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestLastModified.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitPigXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsCountForJobGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsDeleteForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobDeleteJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsActiveCountJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseCountGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobDeleteJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsRunningJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsStatusByPendingFalseJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSuspendedJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetPendingActionsCountJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetRunningActionsCountJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobUpdateJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsToBeMaterializedJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionDeleteJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionRetryManualGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionSubsetGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionUpdateJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsDeleteForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsGetForJobJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowInfoWithActionsSubsetGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobDeleteJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetActionsJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobUpdateJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallbackService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestConfigurationService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestDagXLogInfoService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestELService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestGroupsService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestJPAService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestMemoryLocksService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPauseTransitService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestProxyUserService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchedulerService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchemaService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStoreService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestUUIDService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestXLogService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MyJsonRestServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestCallbackServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestHostnameFilter.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJobsServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJsonRestServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV0JobServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/store/TestSLAStore.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/TestEmbeddedServletContainer.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXFsTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELConstantsFunctions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestIOUtils.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestInstrumentation.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestMemoryLocks.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestParamChecker.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestPriorityDelayQueue.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestWritableUtils.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXConfiguration.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLog.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogReader.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXmlUtils.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSchema.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowLib.java 1308607 
>   trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 1308607 
>   trunk/pom.xml 1308607 
> 
> Diff: https://reviews.apache.org/r/4618/diff
> 
> 
> Testing
> -------
> 
> Ran bin/mkdistro
> 
> 
> Thanks,
> 
> Virag
> 
>

Re: Review Request: oozie-783: Upgrade to Junit4

Posted by Alejandro Abdelnur <tu...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4618/#review6655
-----------------------------------------------------------


In hadoop-land what they've done was upgrading to junit4 and leaving all existing tests as is as junit4 is 100% backwards compat with junit3. 

What is your take on this approach? (I'm not against  this PATCH, just asking to see if that would make sense or not)

- Alejandro


On 2012-04-02 23:34:51, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4618/
> -----------------------------------------------------------
> 
> (Updated 2012-04-02 23:34:51)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> Changes:
> 1) @Test, @After, @Before annotations added
> 2) extends TestCase removed
> 3) Imports added (Some of the imports are unused, but they can be removed together in a separate patch)
> 4) Junit 4 has a different way to obtain testcase method name; added in XTestCase  
> 
> 
> This addresses bug oozie-783.
>     https://issues.apache.org/jira/browse/oozie-783
> 
> 
> Diffs
> -----
> 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestCLIParser.java 1308607 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestValidation.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/TestActionBean.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/TestDagELFunctions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/TestWorkflowBean.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/decision/TestDecisionActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ShellTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestRerun.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutorAsExtension.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/TestLocalOozie.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClientException.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowXClient.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorAction.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorJob.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowAction.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowJob.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/TestCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/TestXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobsXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordJobsXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordResumeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSuspendXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestLastModified.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitPigXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsCountForJobGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsDeleteForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobDeleteJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsActiveCountJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseCountGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobDeleteJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsRunningJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsStatusByPendingFalseJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSuspendedJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetPendingActionsCountJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetRunningActionsCountJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobUpdateJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsToBeMaterializedJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionDeleteJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionRetryManualGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionSubsetGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionUpdateJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsDeleteForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsGetForJobJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowInfoWithActionsSubsetGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobDeleteJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetActionsJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobUpdateJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallbackService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestConfigurationService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestDagXLogInfoService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestELService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestGroupsService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestJPAService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestMemoryLocksService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPauseTransitService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestProxyUserService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchedulerService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchemaService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStoreService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestUUIDService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/service/TestXLogService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MyJsonRestServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestCallbackServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestHostnameFilter.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJobsServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJsonRestServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV0JobServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/store/TestSLAStore.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/TestEmbeddedServletContainer.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXFsTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELConstantsFunctions.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestIOUtils.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestInstrumentation.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestMemoryLocks.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestParamChecker.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestPriorityDelayQueue.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestWritableUtils.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXConfiguration.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLog.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogReader.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXmlUtils.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSchema.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java 1308607 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowLib.java 1308607 
>   trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 1308607 
>   trunk/pom.xml 1308607 
> 
> Diff: https://reviews.apache.org/r/4618/diff
> 
> 
> Testing
> -------
> 
> Ran bin/mkdistro
> 
> 
> Thanks,
> 
> Virag
> 
>

Re: Review Request: oozie-783: Upgrade to Junit4

Posted by Virag Kothari <vi...@yahoo-inc.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4618/
-----------------------------------------------------------

(Updated 2012-05-02 23:03:02.871145)


Review request for oozie and Alejandro Abdelnur.


Changes
-------

Addressing comments. Changes made to pom file only


Summary
-------

Changes:
1) @Test, @After, @Before annotations added
2) extends TestCase removed
3) Imports added (Some of the imports are unused, but they can be removed together in a separate patch)
4) Junit 4 has a different way to obtain testcase method name; added in XTestCase  


This addresses bug oozie-783.
    https://issues.apache.org/jira/browse/oozie-783


Diffs (updated)
-----

  trunk/pom.xml 1333119 

Diff: https://reviews.apache.org/r/4618/diff


Testing
-------

Ran bin/mkdistro


Thanks,

Virag

Re: Review Request: oozie-783: Upgrade to Junit4

Posted by Alejandro Abdelnur <tu...@cloudera.com>.


> On 2012-04-27 22:02:08, Alejandro Abdelnur wrote:
> > Virag,
> > 
> > I know you've done  tons of work here converting all testcase to junit4 annotations.
> > 
> > While that is quite nice, I have the following concern.
> > 
> > Because all tescases have changed in several places (signatures), backporting fixes to 3.1 and 3.2 branches from trunk will require a lot of work because patches will never apply cleanly.
> > 
> > I'd suggest the following approach:
> > 
> > * Upgrade to junit4
> > * leave all junit3 testcases untouch
> > * retrofit XTestCase & XFSTestCase so the work both with junit3 and junit4 testcases
> > * new testcases would be done using junit4
> > 
> > What do you think of this approach?
> 
> Virag Kothari wrote:
>     The original idea to upgrade everything was to run testcases in parallel. However, there are issues running things in parallel which are discussed in oozie-784. Until those issues are resolved, I agree we should not touch existing test cases as backporting might be a problem.
>     
>     Also, once 3.1 and 3.2 become stable, we can think of upgrading everything as backporting may be minimum.
>     
>

gr8, will you be working on an updated patch?


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4618/#review7329
-----------------------------------------------------------


On 2012-04-04 03:58:07, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4618/
> -----------------------------------------------------------
> 
> (Updated 2012-04-04 03:58:07)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> Changes:
> 1) @Test, @After, @Before annotations added
> 2) extends TestCase removed
> 3) Imports added (Some of the imports are unused, but they can be removed together in a separate patch)
> 4) Junit 4 has a different way to obtain testcase method name; added in XTestCase  
> 
> 
> This addresses bug oozie-783.
>     https://issues.apache.org/jira/browse/oozie-783
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/test/java/org/apache/oozie/TestActionBean.java 1309227 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestValidation.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestDagELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestWorkflowBean.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/decision/TestDecisionActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ShellTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestRerun.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutorAsExtension.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestLocalOozie.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClientException.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowXClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorAction.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorJob.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowAction.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowJob.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/TestCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/TestXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobsXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordJobsXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordResumeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSuspendXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestLastModified.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitPigXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsCountForJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsActiveCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseCountGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsRunningJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsStatusByPendingFalseJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1309227 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestCLIParser.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSuspendedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetPendingActionsCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetRunningActionsCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsToBeMaterializedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionRetryManualGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionSubsetGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsGetForJobJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowInfoWithActionsSubsetGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallbackService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestConfigurationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestDagXLogInfoService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestELService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestGroupsService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestJPAService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestMemoryLocksService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPauseTransitService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestProxyUserService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchedulerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchemaService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStoreService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestUUIDService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestXLogService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MyJsonRestServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestCallbackServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestHostnameFilter.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJobsServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJsonRestServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV0JobServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestSLAStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestEmbeddedServletContainer.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXFsTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELConstantsFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestIOUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestInstrumentation.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestMemoryLocks.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestParamChecker.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestPriorityDelayQueue.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestWritableUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXConfiguration.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLog.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogReader.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXmlUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSchema.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowLib.java 1309227 
>   trunk/pom.xml 1309227 
>   trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 1309227 
> 
> Diff: https://reviews.apache.org/r/4618/diff
> 
> 
> Testing
> -------
> 
> Ran bin/mkdistro
> 
> 
> Thanks,
> 
> Virag
> 
>

Re: Review Request: oozie-783: Upgrade to Junit4

Posted by Virag Kothari <vi...@yahoo-inc.com>.


> On 2012-04-27 22:02:08, Alejandro Abdelnur wrote:
> > Virag,
> > 
> > I know you've done  tons of work here converting all testcase to junit4 annotations.
> > 
> > While that is quite nice, I have the following concern.
> > 
> > Because all tescases have changed in several places (signatures), backporting fixes to 3.1 and 3.2 branches from trunk will require a lot of work because patches will never apply cleanly.
> > 
> > I'd suggest the following approach:
> > 
> > * Upgrade to junit4
> > * leave all junit3 testcases untouch
> > * retrofit XTestCase & XFSTestCase so the work both with junit3 and junit4 testcases
> > * new testcases would be done using junit4
> > 
> > What do you think of this approach?
> 
> Virag Kothari wrote:
>     The original idea to upgrade everything was to run testcases in parallel. However, there are issues running things in parallel which are discussed in oozie-784. Until those issues are resolved, I agree we should not touch existing test cases as backporting might be a problem.
>     
>     Also, once 3.1 and 3.2 become stable, we can think of upgrading everything as backporting may be minimum.
>     
>
> 
> Alejandro Abdelnur wrote:
>     gr8, will you be working on an updated patch?

Yup, next week


- Virag


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4618/#review7329
-----------------------------------------------------------


On 2012-04-04 03:58:07, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4618/
> -----------------------------------------------------------
> 
> (Updated 2012-04-04 03:58:07)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> Changes:
> 1) @Test, @After, @Before annotations added
> 2) extends TestCase removed
> 3) Imports added (Some of the imports are unused, but they can be removed together in a separate patch)
> 4) Junit 4 has a different way to obtain testcase method name; added in XTestCase  
> 
> 
> This addresses bug oozie-783.
>     https://issues.apache.org/jira/browse/oozie-783
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/test/java/org/apache/oozie/TestActionBean.java 1309227 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestValidation.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestDagELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestWorkflowBean.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/decision/TestDecisionActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ShellTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestRerun.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutorAsExtension.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestLocalOozie.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClientException.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowXClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorAction.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorJob.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowAction.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowJob.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/TestCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/TestXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobsXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordJobsXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordResumeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSuspendXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestLastModified.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitPigXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsCountForJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsActiveCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseCountGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsRunningJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsStatusByPendingFalseJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1309227 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestCLIParser.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSuspendedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetPendingActionsCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetRunningActionsCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsToBeMaterializedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionRetryManualGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionSubsetGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsGetForJobJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowInfoWithActionsSubsetGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallbackService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestConfigurationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestDagXLogInfoService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestELService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestGroupsService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestJPAService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestMemoryLocksService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPauseTransitService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestProxyUserService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchedulerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchemaService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStoreService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestUUIDService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestXLogService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MyJsonRestServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestCallbackServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestHostnameFilter.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJobsServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJsonRestServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV0JobServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestSLAStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestEmbeddedServletContainer.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXFsTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELConstantsFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestIOUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestInstrumentation.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestMemoryLocks.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestParamChecker.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestPriorityDelayQueue.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestWritableUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXConfiguration.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLog.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogReader.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXmlUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSchema.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowLib.java 1309227 
>   trunk/pom.xml 1309227 
>   trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 1309227 
> 
> Diff: https://reviews.apache.org/r/4618/diff
> 
> 
> Testing
> -------
> 
> Ran bin/mkdistro
> 
> 
> Thanks,
> 
> Virag
> 
>

Re: Review Request: oozie-783: Upgrade to Junit4

Posted by Virag Kothari <vi...@yahoo-inc.com>.


> On 2012-04-27 22:02:08, Alejandro Abdelnur wrote:
> > Virag,
> > 
> > I know you've done  tons of work here converting all testcase to junit4 annotations.
> > 
> > While that is quite nice, I have the following concern.
> > 
> > Because all tescases have changed in several places (signatures), backporting fixes to 3.1 and 3.2 branches from trunk will require a lot of work because patches will never apply cleanly.
> > 
> > I'd suggest the following approach:
> > 
> > * Upgrade to junit4
> > * leave all junit3 testcases untouch
> > * retrofit XTestCase & XFSTestCase so the work both with junit3 and junit4 testcases
> > * new testcases would be done using junit4
> > 
> > What do you think of this approach?

The original idea to upgrade everything was to run testcases in parallel. However, there are issues running things in parallel which are discussed in oozie-784. Until those issues are resolved, I agree we should not touch existing test cases as backporting might be a problem.

Also, once 3.1 and 3.2 become stable, we can think of upgrading everything as backporting may be minimum.


- Virag


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4618/#review7329
-----------------------------------------------------------


On 2012-04-04 03:58:07, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4618/
> -----------------------------------------------------------
> 
> (Updated 2012-04-04 03:58:07)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> Changes:
> 1) @Test, @After, @Before annotations added
> 2) extends TestCase removed
> 3) Imports added (Some of the imports are unused, but they can be removed together in a separate patch)
> 4) Junit 4 has a different way to obtain testcase method name; added in XTestCase  
> 
> 
> This addresses bug oozie-783.
>     https://issues.apache.org/jira/browse/oozie-783
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/test/java/org/apache/oozie/TestActionBean.java 1309227 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestValidation.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestDagELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestWorkflowBean.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/decision/TestDecisionActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ShellTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestRerun.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutorAsExtension.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestLocalOozie.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClientException.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowXClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorAction.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorJob.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowAction.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowJob.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/TestCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/TestXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobsXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordJobsXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordResumeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSuspendXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestLastModified.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitPigXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsCountForJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsActiveCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseCountGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsRunningJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsStatusByPendingFalseJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1309227 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestCLIParser.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSuspendedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetPendingActionsCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetRunningActionsCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsToBeMaterializedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionRetryManualGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionSubsetGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsGetForJobJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowInfoWithActionsSubsetGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallbackService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestConfigurationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestDagXLogInfoService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestELService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestGroupsService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestJPAService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestMemoryLocksService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPauseTransitService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestProxyUserService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchedulerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchemaService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStoreService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestUUIDService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestXLogService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MyJsonRestServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestCallbackServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestHostnameFilter.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJobsServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJsonRestServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV0JobServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestSLAStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestEmbeddedServletContainer.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXFsTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELConstantsFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestIOUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestInstrumentation.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestMemoryLocks.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestParamChecker.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestPriorityDelayQueue.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestWritableUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXConfiguration.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLog.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogReader.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXmlUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSchema.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowLib.java 1309227 
>   trunk/pom.xml 1309227 
>   trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 1309227 
> 
> Diff: https://reviews.apache.org/r/4618/diff
> 
> 
> Testing
> -------
> 
> Ran bin/mkdistro
> 
> 
> Thanks,
> 
> Virag
> 
>

Re: Review Request: oozie-783: Upgrade to Junit4

Posted by Alejandro Abdelnur <tu...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4618/#review7329
-----------------------------------------------------------


Virag,

I know you've done  tons of work here converting all testcase to junit4 annotations.

While that is quite nice, I have the following concern.

Because all tescases have changed in several places (signatures), backporting fixes to 3.1 and 3.2 branches from trunk will require a lot of work because patches will never apply cleanly.

I'd suggest the following approach:

* Upgrade to junit4
* leave all junit3 testcases untouch
* retrofit XTestCase & XFSTestCase so the work both with junit3 and junit4 testcases
* new testcases would be done using junit4

What do you think of this approach?

- Alejandro


On 2012-04-04 03:58:07, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4618/
> -----------------------------------------------------------
> 
> (Updated 2012-04-04 03:58:07)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> Changes:
> 1) @Test, @After, @Before annotations added
> 2) extends TestCase removed
> 3) Imports added (Some of the imports are unused, but they can be removed together in a separate patch)
> 4) Junit 4 has a different way to obtain testcase method name; added in XTestCase  
> 
> 
> This addresses bug oozie-783.
>     https://issues.apache.org/jira/browse/oozie-783
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/test/java/org/apache/oozie/TestActionBean.java 1309227 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestValidation.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestDagELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestWorkflowBean.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/decision/TestDecisionActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ShellTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestRerun.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutorAsExtension.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestLocalOozie.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClientException.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowXClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorAction.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorJob.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowAction.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowJob.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/TestCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/TestXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobsXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordJobsXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordResumeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSuspendXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestLastModified.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitPigXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsCountForJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsActiveCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseCountGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsRunningJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsStatusByPendingFalseJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1309227 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestCLIParser.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSuspendedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetPendingActionsCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetRunningActionsCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsToBeMaterializedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionRetryManualGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionSubsetGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsGetForJobJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowInfoWithActionsSubsetGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallbackService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestConfigurationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestDagXLogInfoService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestELService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestGroupsService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestJPAService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestMemoryLocksService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPauseTransitService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestProxyUserService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchedulerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchemaService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStoreService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestUUIDService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestXLogService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MyJsonRestServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestCallbackServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestHostnameFilter.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJobsServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJsonRestServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV0JobServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestSLAStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestEmbeddedServletContainer.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXFsTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELConstantsFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestIOUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestInstrumentation.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestMemoryLocks.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestParamChecker.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestPriorityDelayQueue.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestWritableUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXConfiguration.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLog.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogReader.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXmlUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSchema.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowLib.java 1309227 
>   trunk/pom.xml 1309227 
>   trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 1309227 
> 
> Diff: https://reviews.apache.org/r/4618/diff
> 
> 
> Testing
> -------
> 
> Ran bin/mkdistro
> 
> 
> Thanks,
> 
> Virag
> 
>

Re: Review Request: oozie-783: Upgrade to Junit4

Posted by Virag Kothari <vi...@yahoo-inc.com>.


> On 2012-04-05 14:10:12, Alejandro Abdelnur wrote:
> > I've applied the patch to trunk & run testcases; getting the following failures:
> > 
> > 
> > Tests in error: 
> >   testBasicSubmitWithMultipleInstancesInputEvent(org.apache.oozie.command.coord.TestCoordSubmitXCommand): file:/Volumes/SSD/src/apache/oozie/svn/trunk0/core/target/test-data/oozietests/org.apache.oozie.command.coord.TestCoordSubmitXCommand/testBasicSubmitWithMultipleInstancesInputEvent/coordinator.xml (No such file or directory)
> >   testBasicSubmitWithMultipleInstancesOutputEvent(org.apache.oozie.command.coord.TestCoordSubmitXCommand): file:/Volumes/SSD/src/apache/oozie/svn/trunk0/core/target/test-data/oozietests/org.apache.oozie.command.coord.TestCoordSubmitXCommand/testBasicSubmitWithMultipleInstancesOutputEvent/coordinator.xml (No such file or directory)
> >   testDecision(org.apache.oozie.action.decision.TestDecisionActionExecutor)
> > 
> >

Both failing due to reasons not related to junit4; addressed in 804 and 805


- Virag


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4618/#review6710
-----------------------------------------------------------


On 2012-04-04 03:58:07, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4618/
> -----------------------------------------------------------
> 
> (Updated 2012-04-04 03:58:07)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> Changes:
> 1) @Test, @After, @Before annotations added
> 2) extends TestCase removed
> 3) Imports added (Some of the imports are unused, but they can be removed together in a separate patch)
> 4) Junit 4 has a different way to obtain testcase method name; added in XTestCase  
> 
> 
> This addresses bug oozie-783.
>     https://issues.apache.org/jira/browse/oozie-783
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/test/java/org/apache/oozie/TestActionBean.java 1309227 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestValidation.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestDagELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestWorkflowBean.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/decision/TestDecisionActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ShellTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestRerun.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutorAsExtension.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestLocalOozie.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClientException.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowXClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorAction.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorJob.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowAction.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowJob.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/TestCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/TestXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobsXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordJobsXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordResumeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSuspendXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestLastModified.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitPigXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsCountForJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsActiveCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseCountGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsRunningJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsStatusByPendingFalseJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1309227 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestCLIParser.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSuspendedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetPendingActionsCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetRunningActionsCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsToBeMaterializedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionRetryManualGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionSubsetGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsGetForJobJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowInfoWithActionsSubsetGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallbackService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestConfigurationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestDagXLogInfoService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestELService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestGroupsService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestJPAService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestMemoryLocksService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPauseTransitService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestProxyUserService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchedulerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchemaService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStoreService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestUUIDService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestXLogService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MyJsonRestServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestCallbackServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestHostnameFilter.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJobsServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJsonRestServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV0JobServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestSLAStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestEmbeddedServletContainer.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXFsTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELConstantsFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestIOUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestInstrumentation.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestMemoryLocks.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestParamChecker.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestPriorityDelayQueue.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestWritableUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXConfiguration.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLog.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogReader.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXmlUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSchema.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowLib.java 1309227 
>   trunk/pom.xml 1309227 
>   trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 1309227 
> 
> Diff: https://reviews.apache.org/r/4618/diff
> 
> 
> Testing
> -------
> 
> Ran bin/mkdistro
> 
> 
> Thanks,
> 
> Virag
> 
>

Re: Review Request: oozie-783: Upgrade to Junit4

Posted by Alejandro Abdelnur <tu...@cloudera.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4618/#review6710
-----------------------------------------------------------


I've applied the patch to trunk & run testcases; getting the following failures:


Tests in error: 
  testBasicSubmitWithMultipleInstancesInputEvent(org.apache.oozie.command.coord.TestCoordSubmitXCommand): file:/Volumes/SSD/src/apache/oozie/svn/trunk0/core/target/test-data/oozietests/org.apache.oozie.command.coord.TestCoordSubmitXCommand/testBasicSubmitWithMultipleInstancesInputEvent/coordinator.xml (No such file or directory)
  testBasicSubmitWithMultipleInstancesOutputEvent(org.apache.oozie.command.coord.TestCoordSubmitXCommand): file:/Volumes/SSD/src/apache/oozie/svn/trunk0/core/target/test-data/oozietests/org.apache.oozie.command.coord.TestCoordSubmitXCommand/testBasicSubmitWithMultipleInstancesOutputEvent/coordinator.xml (No such file or directory)
  testDecision(org.apache.oozie.action.decision.TestDecisionActionExecutor)



- Alejandro


On 2012-04-04 03:58:07, Virag Kothari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4618/
> -----------------------------------------------------------
> 
> (Updated 2012-04-04 03:58:07)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> Changes:
> 1) @Test, @After, @Before annotations added
> 2) extends TestCase removed
> 3) Imports added (Some of the imports are unused, but they can be removed together in a separate patch)
> 4) Junit 4 has a different way to obtain testcase method name; added in XTestCase  
> 
> 
> This addresses bug oozie-783.
>     https://issues.apache.org/jira/browse/oozie-783
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/test/java/org/apache/oozie/TestActionBean.java 1309227 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestValidation.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestDagELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/TestWorkflowBean.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/decision/TestDecisionActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/ShellTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestRerun.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutorAsExtension.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestLocalOozie.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClientException.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowXClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorAction.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorJob.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowAction.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowJob.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/TestCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/TestXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobsXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordJobsXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordResumeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSuspendXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestLastModified.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitPigXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsCountForJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsActiveCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseCountGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsRunningJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsStatusByPendingFalseJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1309227 
>   trunk/client/src/test/java/org/apache/oozie/cli/TestCLIParser.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSuspendedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetPendingActionsCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetRunningActionsCountJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsToBeMaterializedJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionRetryManualGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionSubsetGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsDeleteForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsGetForJobJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowInfoWithActionsSubsetGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobDeleteJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetActionsJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobUpdateJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestActionService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCallbackService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestConfigurationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestDagXLogInfoService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestELService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestGroupsService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestJPAService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestMemoryLocksService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPauseTransitService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestProxyUserService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchedulerService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestSchemaService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestStoreService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestUUIDService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/service/TestXLogService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/MyJsonRestServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestCallbackServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestHostnameFilter.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJobsServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestJsonRestServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV0JobServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/store/TestSLAStore.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestEmbeddedServletContainer.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXFsTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/TestXTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELConstantsFunctions.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestIOUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestInstrumentation.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestMemoryLocks.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestParamChecker.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestPriorityDelayQueue.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestWritableUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXConfiguration.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLog.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXLogReader.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/TestXmlUtils.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSchema.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java 1309227 
>   trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowLib.java 1309227 
>   trunk/pom.xml 1309227 
>   trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 1309227 
> 
> Diff: https://reviews.apache.org/r/4618/diff
> 
> 
> Testing
> -------
> 
> Ran bin/mkdistro
> 
> 
> Thanks,
> 
> Virag
> 
>

Re: Review Request: oozie-783: Upgrade to Junit4

Posted by Virag Kothari <vi...@yahoo-inc.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4618/
-----------------------------------------------------------

(Updated 2012-04-04 03:58:07.031366)


Review request for oozie.


Changes
-------

Based on discussion with Alejandro, explicitly setting the threads to 1 as running in parallel has issues discussed in oozie-784


Summary
-------

Changes:
1) @Test, @After, @Before annotations added
2) extends TestCase removed
3) Imports added (Some of the imports are unused, but they can be removed together in a separate patch)
4) Junit 4 has a different way to obtain testcase method name; added in XTestCase  


This addresses bug oozie-783.
    https://issues.apache.org/jira/browse/oozie-783


Diffs (updated)
-----

  trunk/core/src/test/java/org/apache/oozie/TestActionBean.java 1309227 
  trunk/client/src/test/java/org/apache/oozie/cli/TestValidation.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/TestDagELFunctions.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/TestWorkflowBean.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/TestActionExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/decision/TestDecisionActionExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/ShellTestCase.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsELFunctions.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHadoopELFunctions.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceMain.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPipesMain.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestRerun.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestStreamingMain.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/action/ssh/TestSshActionExecutorAsExtension.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/client/TestLocalOozie.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowClientException.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/client/TestWorkflowXClient.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorAction.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonCoordinatorJob.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowAction.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/client/rest/TestJsonWorkflowJob.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/TestCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/TestXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobSuspendXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobsXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleKillXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePauseUnpauseXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundlePurgeXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleRerunXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/bundle/TestBundleStartXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/coord/CoordXTestCase.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionInputCheckXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionMaterializeCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionStartXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordJobsXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordKillXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordPurgeXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordResumeXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSuspendXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestFutureActionsTimeOut.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/coord/TestPastActionsTimeOut.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionErrors.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestLastModified.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestPurgeXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitPigXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/command/wf/TestWorkflowKillXCommand.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELEvaluator.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsCountForJobGetJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleActionsDeleteForPurgeJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobDeleteJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobsGetForPurgeJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetForExternalIdJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionGetJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionUpdateStatusJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsActiveCountJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteForPurgeJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForJobJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseCountGetJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsPendingFalseStatusCountGetJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsRunningGetJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobDeleteJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionByActionNumberJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionForNominalTimeJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsForDatesJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsNotCompletedJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsRunningJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsStatusByPendingFalseJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java 1309227 
  trunk/client/src/test/java/org/apache/oozie/cli/TestCLIParser.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSuspendedJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetPendingActionsCountJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetReadyActionsJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetRunningActionsCountJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobUpdateJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetForPurgeJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsToBeMaterializedJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForSeqIdJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionDeleteJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionRetryManualGetJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionSubsetGetJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionUpdateJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsDeleteForPurgeJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsGetForJobJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionsRunningGetJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowIdGetForExternalIdJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowInfoWithActionsSubsetGetJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobDeleteJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetActionsJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobGetJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobUpdateJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowJobsGetForPurgeJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestActionCheckerService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestActionService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestCallbackService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestConfigurationService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestCoordMaterializeTriggerService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestDagXLogInfoService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestELService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestGroupsService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestInstrumentationService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestJPAService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowStoreService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestMemoryLocksService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestPauseTransitService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestProxyUserService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestPurgeService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestSchedulerService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestSchemaService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestServices.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestStoreService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestUUIDService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/service/TestXLogService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/servlet/DagServletTestCase.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/servlet/MyJsonRestServlet.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestAuthFilterAuthOozieClient.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestCallbackServlet.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestHostnameFilter.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestJobsServlet.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestJsonRestServlet.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestV0JobServlet.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/servlet/TestVersionServlet.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/store/TestCoordinatorStore.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/store/TestDBWorkflowStore.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/store/TestSLAStore.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/test/MiniOozieTestCase.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/test/TestEmbeddedServletContainer.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/test/TestXFsTestCase.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/test/TestXTestCase.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/TestClassUtils.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/TestELConstantsFunctions.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/TestELEvaluator.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/TestIOUtils.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/TestInstrumentation.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/TestMemoryLocks.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/TestParamChecker.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/TestPriorityDelayQueue.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/TestWritableUtils.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/TestXConfiguration.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/TestXLog.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/TestXLogReader.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/TestXmlUtils.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/db/TestSchema.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/util/db/TestSqlStatement.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java 1309227 
  trunk/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowLib.java 1309227 
  trunk/pom.xml 1309227 
  trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 1309227 

Diff: https://reviews.apache.org/r/4618/diff


Testing
-------

Ran bin/mkdistro


Thanks,

Virag