[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #610: Add ST_Disjoint predicate

[GitBox <gi...@apache.org>]

jiayuasu commented on code in PR #610:
URL: https://github.com/apache/incubator-sedona/pull/610#discussion_r851663093


##########
docs/archive/api/sql/GeoSparkSQL-Predicate.md:
##########
@@ -100,4 +100,19 @@ Spark SQL example:
 SELECT *
 FROM geom
 WHERE ST_Overlaps(geom.geom_a, geom.geom_b)
+```
+
+## ST_Disjoint
+
+Introduction: Return true if A and B are disjoint
+
+Format: `ST_Disjoint (A:geometry, B:geometry)`
+
+Since: `v1.2.0`

Review Comment:
   version is 1.2.1



##########
sql/src/main/scala/org/apache/spark/sql/sedona_sql/strategy/join/JoinQueryDetector.scala:
##########
@@ -69,6 +69,8 @@ class JoinQueryDetector(sparkSession: SparkSession) extends Strategy {
           Some(JoinQueryDetection(left, right, leftShape, rightShape, false, extraCondition))
         case ST_Crosses(Seq(leftShape, rightShape)) =>
           Some(JoinQueryDetection(right, left, rightShape, leftShape, false, extraCondition))
+        case ST_Disjoint(Seq(leftShape, rightShape)) =>

Review Comment:
   You shouldn't put Disjoint here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org