You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Ashwani Raina (Code Review)" <ge...@cloudera.org> on 2025/09/10 11:36:52 UTC
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Ashwani Raina has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23411
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
KUDU-1457 [4/n] enable webserver for IPv6
This patch enables webserver to make use of IPv6.
- Adds build flag (USE_IPV6) to squeasel for IPv6 support for users.
- Set appropriate bind interface for http based on webserver ip mode.
- Augment GetBoundAddresses() to enable fetching of IPv6 address.
- Introduce webserver_ip_mode flag for test purpose that can be used to
set it corresponding variable inside WebserverOptions. This is used
to at the time of initialisation of webserver object and set
http_address_ correctly based on which IP mode is chosen.
- Added parallel suite of tests to webserver-test and mini_master-test.
- Additional manual testing is also performed to ensure webserver is
correctly hosted on IPv6 interfaces and the endpoint is capable of
performing http methods.
Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
---
M src/kudu/master/mini_master-test.cc
M src/kudu/master/mini_master.cc
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webserver_options.cc
M src/kudu/server/webserver_options.h
M thirdparty/build-definitions.sh
7 files changed, 372 insertions(+), 77 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/23411/1
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23411
to look at the new patch set (#6).
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
KUDU-1457 [4/n] enable webserver for IPv6
This patch mainly does two things - enable webserver to make use of
IPv6 and introduce a ip config flag that can be used to choose IP
protocol for various communication channels. More details as follows:
- Add build flag (USE_IPV6) to squeasel for IPv6 support for users.
- Set appropriate bind interface for http based on webserver ip mode.
- Augment GetBoundAddresses() to enable fetching of IPv6 address.
- Introduce ip_config_mode flag that can be configured by a user if need
arises to override the default mode i.e. ipv4. One of the purposes of
this flag is to serve a hint inside various server modules like rpc,
webserver, etc to regulate the protocol used for communication.
- Set default value of --webserver_interface flag to 0.0.0.0. The value
is used as bind interface during webserver object initialisation.
- Reduce frequency of 'master address resolution to multiple addresses'
warning once a minute to reduce flooding of logs with such message
when hostname resolves to multiple addresses.
- Add parallel suite of tests to webserver-test and mini_master-test.
- Additional manual testing is also performed to ensure webserver is
correctly hosted on IPv6 interfaces and the endpoint is capable of
performing http methods.
- Manual testing for different combinations with servers running on
IPv4,IPv6 and Dual stack address endpoints and Kudu CLI able to
connect with servers and perform basic operations like ksck,
'perf loadgen', table list, etc. Kudu CLI also makes use of the ip
config mode flag to enforce the IP communication protocol.
Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
---
M src/kudu/master/mini_master-test.cc
M src/kudu/master/mini_master.cc
M src/kudu/scripts/start_kudu.sh
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webserver_options.cc
M src/kudu/tserver/heartbeater.cc
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/net/net_util.h
M thirdparty/build-definitions.sh
11 files changed, 408 insertions(+), 104 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/23411/6
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 6
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 4:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1871/
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 4
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 26 Sep 2025 14:09:25 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23411
to look at the new patch set (#5).
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
KUDU-1457 [4/n] enable webserver for IPv6
This patch mainly does two things - enable webserver to make use of
IPv6 and introduce a ip config flag that can be used to choose IP
protocol for various communication channels. More details as follows:
- Add build flag (USE_IPV6) to squeasel for IPv6 support for users.
- Set appropriate bind interface for http based on webserver ip mode.
- Augment GetBoundAddresses() to enable fetching of IPv6 address.
- Introduce ip_config_mode flag that can be configured by a user if need
arises to override the default mode i.e. ipv4. One of the purposes of
this flag is to serve a hint inside various server modules like rpc,
webserver, etc to regulate the protocol used for communication.
- Set default value of --webserver_interface flag to 0.0.0.0. The value
is used as bind interface during webserver object initialisation.
- Reduce frequency of 'master address resolution to multiple addresses'
warning once a minute to reduce flooding of logs with such message
when hostname resolves to multiple addresses.
- Add parallel suite of tests to webserver-test and mini_master-test.
- Additional manual testing is also performed to ensure webserver is
correctly hosted on IPv6 interfaces and the endpoint is capable of
performing http methods.
- Manual testing for different combinations with servers running on
IPv4,IPv6 and Dual stack address endpoints and Kudu CLI able to
connect with servers and perform basic operations like ksck,
'perf loadgen', table list, etc. Kudu CLI also makes use of the ip
config mode flag to enforce the IP communication protocol.
Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
---
M src/kudu/master/mini_master-test.cc
M src/kudu/master/mini_master.cc
M src/kudu/scripts/start_kudu.sh
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webserver_options.cc
M src/kudu/tserver/heartbeater.cc
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
M thirdparty/build-definitions.sh
10 files changed, 344 insertions(+), 98 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/23411/5
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 5
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23411
to look at the new patch set (#3).
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
KUDU-1457 [4/n] enable webserver for IPv6
This patch mainly does two things - enables webserver to make use of
IPv6 and introduces a ip config flag that can be used to choose IP
protocol for various communication channels. More details as follows:
- Adds build flag (USE_IPV6) to squeasel for IPv6 support for users.
- Set appropriate bind interface for http based on webserver ip mode.
- Augment GetBoundAddresses() to enable fetching of IPv6 address.
- Introduce ip_config_mode flag that can be configured by a user if need
arises to override the default mode i.e. ipv4. The main purpose of
this flag is to serve a hint inside various server modules like rpc,
webserver, etc to regulate the protocol used for communication.
- Added parallel suite of tests to webserver-test and mini_master-test.
- Additional manual testing is also performed to ensure webserver is
correctly hosted on IPv6 interfaces and the endpoint is capable of
performing http methods.
Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
---
M src/kudu/master/mini_master-test.cc
M src/kudu/master/mini_master.cc
M src/kudu/server/server_base.cc
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/util/net/net_util.cc
M thirdparty/build-definitions.sh
7 files changed, 272 insertions(+), 83 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/23411/3
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 3
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1786/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 10 Sep 2025 13:10:02 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23411
to look at the new patch set (#2).
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
KUDU-1457 [4/n] enable webserver for IPv6
This patch mainly does two things - enables webserver to make use of
IPv6 and introduces a ip config flag that can be used to choose IP
protocol for various communication channels. More details as follows:
- Adds build flag (USE_IPV6) to squeasel for IPv6 support for users.
- Set appropriate bind interface for http based on webserver ip mode.
- Augment GetBoundAddresses() to enable fetching of IPv6 address.
- Introduce ip_config_mode flag that can be configured by a user if need
arises to override the default mode i.e. ipv4. The main purpose of
this flag is to serve a hint inside various server modules like rpc,
webserver, etc to regulate the protocol used for communication.
- Added parallel suite of tests to webserver-test and mini_master-test.
- Additional manual testing is also performed to ensure webserver is
correctly hosted on IPv6 interfaces and the endpoint is capable of
performing http methods.
Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
---
M src/kudu/master/mini_master-test.cc
M src/kudu/master/mini_master.cc
M src/kudu/server/server_base.cc
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webserver_options.cc
M thirdparty/build-definitions.sh
7 files changed, 269 insertions(+), 84 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/23411/2
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 8: Code-Review+1
(6 comments)
PS11 looks better. Just a few nits and questions.
Thanks a lot for revving this!
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/master/mini_master.cc
File src/kudu/master/mini_master.cc:
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/master/mini_master.cc@70
PS5, Line 70:
> This is just one time usage here. Even though similar sort manipulation is
Thanks for checking this out.
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc
File src/kudu/server/webserver-test.cc:
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@188
PS5, Line 188: verTest {
Thanks a lot for the explanation.
> Shouldn't there be coverage for the 'dual' mode well?
Whoops, for some reason, I wrote 'dual' there instead of 'ipv6' -- not sure why.
> In theory, we could have all three modes for all the tests, but it would not serve much purpose.
I guess there might be a need to have strict 'ipv6' mode tests if we want to make sure that nothing but 'ipv6' addresses are used if both 'ipv4' and 'ipv6' stacks are available. If you know this isn't something that we need to test for as of now, having just 'ipv4' and 'dual' should be enough, I agree.
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@1017
PS5, Line 1017:
> I am not really keen on crashing with SIGABRT.
I guess it would require changing the signature of this method to start using FAIL() here instead. If that's too much, and given that in PS8 there is also CHECK_OK() for ParseIPModeFlag(), having CHECK() might be the most straightforward way of updating this existing code. It's up to you -- this is just a nit after all, and I'm fine if keeping CHECK() here as-is.
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver_options.cc
File src/kudu/server/webserver_options.cc:
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver_options.cc@47
PS5, Line 47: 0.0.0.0
> This aligns with --rpc_bind_addresses that is also set to default 'unspecified' address.
Right, but that was for IPv4 only. I'm just pointing to the fact that with introduction of the IP config mode concept it would make sense to keep this flag's default value empty and change its semantics correspondingly, and maybe change the rpc_bind_addresses's default value to an empty string as well, with semantics of binding to 'wildcard' address (whatever it means for an IP config mode) if a flag is set to an empty string. With that, it would be more consistent with any setting of the --ip_config_mode flag.
What do you think?
http://gerrit.cloudera.org:8080/#/c/23411/8/src/kudu/util/net/net_util.cc
File src/kudu/util/net/net_util.cc:
http://gerrit.cloudera.org:8080/#/c/23411/8/src/kudu/util/net/net_util.cc@170
PS8, Line 170: Status ParseIPModeFlag(const char* flag_name,
: const string& flag_value,
: IPMode* mode) {
: if (iequals(flag_value, "ipv4")) {
: *mode = IPMode::IPV4;
: } else if (iequals(flag_value, "ipv6")) {
: *mode = IPMode::IPV6;
: } else if (iequals(flag_value, "dual")) {
: *mode = IPMode::DUAL;
: } else {
: return Status::InvalidArgument(
: Substitute("$0: invalid value for flag --$1, can be one of "
: "'ipv4', 'ipv6', 'dual'; case insensitive",
: flag_value, flag_name));
: }
: return Status::OK();
: }
Do we expect to the ip_config_mode flag change in runtime? If not, consider having a function that parses the flag just once when the function is called first time (e.g., it's possible to use std::once for that) and then reuse the result on follow-up calls.
Also, do we need to have this parameterized by flag name at all? If this isn't used elsewhere for a different flag, why to have these two first parameters?
http://gerrit.cloudera.org:8080/#/c/23411/8/src/kudu/util/net/net_util.cc@515
PS8, Line 515: if (PREDICT_FALSE(out == nullptr)) {
: return Status::InvalidArgument("null output string");
: }
nit: usually, this is done using DCHECK() -- since the variability of the nullness for the 'out' parameter comes from the code (not from the data), it's enough to have DCHECK() to catch programming errors
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 8
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 08:38:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23411
to look at the new patch set (#4).
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
KUDU-1457 [4/n] enable webserver for IPv6
This patch mainly does two things - enables webserver to make use of
IPv6 and introduces a ip config flag that can be used to choose IP
protocol for various communication channels. More details as follows:
- Adds build flag (USE_IPV6) to squeasel for IPv6 support for users.
- Set appropriate bind interface for http based on webserver ip mode.
- Augment GetBoundAddresses() to enable fetching of IPv6 address.
- Introduce ip_config_mode flag that can be configured by a user if need
arises to override the default mode i.e. ipv4. The main purpose of
this flag is to serve a hint inside various server modules like rpc,
webserver, etc to regulate the protocol used for communication.
- Added parallel suite of tests to webserver-test and mini_master-test.
- Additional manual testing is also performed to ensure webserver is
correctly hosted on IPv6 interfaces and the endpoint is capable of
performing http methods.
Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
---
M src/kudu/master/mini_master-test.cc
M src/kudu/master/mini_master.cc
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/util/net/net_util.cc
M thirdparty/build-definitions.sh
6 files changed, 271 insertions(+), 83 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/23411/4
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 4
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 10:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1942/
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 10
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 20:32:43 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23411
to look at the new patch set (#7).
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
KUDU-1457 [4/n] enable webserver for IPv6
This patch mainly does two things - enable webserver to make use of
IPv6 and introduce a ip config flag that can be used to choose IP
protocol for various communication channels. More details as follows:
- Add build flag (USE_IPV6) to squeasel for IPv6 support for users.
- Set appropriate bind interface for http based on webserver ip mode.
- Augment GetBoundAddresses() to enable fetching of IPv6 address.
- Introduce ip_config_mode flag that can be configured by a user if need
arises to override the default mode i.e. ipv4. One of the purposes of
this flag is to serve a hint inside various server modules like rpc,
webserver, etc to regulate the protocol used for communication.
- Set default value of --webserver_interface flag to 0.0.0.0. The value
is used as bind interface during webserver object initialisation.
- Reduce frequency of 'master address resolution to multiple addresses'
warning once a minute to reduce flooding of logs with such message
when hostname resolves to multiple addresses.
- Add parallel suite of tests to webserver-test and mini_master-test.
- Additional manual testing is also performed to ensure webserver is
correctly hosted on IPv6 interfaces and the endpoint is capable of
performing http methods.
- Fix a bug in java client net utils to ensure that input address is
correctly parsed into host and port for different IPv6 address
combinations.
- Manual testing for different combinations with servers running on
IPv4,IPv6 and Dual stack address endpoints and Kudu CLI able to
connect with servers and perform basic operations like ksck,
'perf loadgen', table list, etc. Kudu CLI also makes use of the ip
config mode flag to enforce the IP communication protocol.
Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
---
M java/kudu-client/src/main/java/org/apache/kudu/util/NetUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestNetUtil.java
M src/kudu/master/mini_master-test.cc
M src/kudu/master/mini_master.cc
M src/kudu/scripts/start_kudu.sh
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webserver_options.cc
M src/kudu/tserver/heartbeater.cc
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/net/net_util.h
M thirdparty/build-definitions.sh
13 files changed, 435 insertions(+), 107 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/23411/7
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 7
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 5:
(20 comments)
First quick review round.
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/master/mini_master-test.cc
File src/kudu/master/mini_master-test.cc:
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/master/mini_master-test.cc@40
PS5, Line 40: class MiniMasterTest : public KuduTest,
: public ::testing::WithParamInterface<std::string> {
: protected:
: static std::string get_host() {
: FLAGS_ip_config_mode = GetParam();
: if (FLAGS_ip_config_mode == "ipv6") {
: return "::1";
: }
: return "127.0.0.1";
: }
: };
:
: // This is used to run all parameterized tests with different IP modes.
: INSTANTIATE_TEST_SUITE_P(Parameters, MiniMasterTest,
: testing::Values("ipv4", "ipv6"));
Shouldn't there be coverage for the 'dual' mode here as well?
Most likely I'm missing something here, but if not adding such coverage in this test, where are you going to have the 'dual' mode covered then?
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/master/mini_master.cc
File src/kudu/master/mini_master.cc:
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/master/mini_master.cc@70
PS5, Line 70: "[" + web_bind_addr.host() + "]"
Shouldn't this be somehow encapsulated into HostPort or just a stand-alone method in network utilitues instead of doing this manually with all the boiler plate in all the places? Maybe, add a new 'ToIpInterface()' method into HostPort for this?
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc
File src/kudu/server/webserver-test.cc:
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@188
PS5, Line 188: "ipv4", "dual"
Why 'ipv6' is omitted? Could you at least add a comment about the reason?
Shouldn't there be coverage for the 'dual' mode well? Most likely I'm missing something, but I'm not sure I saw a single test scenario where the 'dual' mode would be covered.
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@288
PS5, Line 288: "ipv4", "dual"
ditto regarding the omitted 'ipv6'
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@299
PS5, Line 299: "ipv4", "dual"
ditto regarding the omitted 'ipv6'
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@425
PS5, Line 425: ipv4", "dual
ditto regarding the omitted 'ipv6'
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@526
PS5, Line 526: pv4", "dual
ditto regarding the omitted 'ipv6'
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@539
PS5, Line 539: ipv4", "dual
ditto regarding the omitted 'ipv6'
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@744
PS5, Line 744: ipv4", "dual
ditto regarding the omitted 'ipv6'
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@753
PS5, Line 753: ipv4", "dual
ditto regarding the omitted 'ipv6'
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@830
PS5, Line 830: "ipv4", "dual")
ditto regarding the omitted 'ipv6'
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@893
PS5, Line 893: "ipv4", "dual"
ditto regarding the omitted 'ipv6'
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@994
PS5, Line 994: "127.0.0.1"
nit: why not to use expected_advertised_host_ here as well?
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@1017
PS5, Line 1017: CHECK(false)
nit: would calling FAIL() and returning an empty string fit here, or you explicitly want it to crash with SIGABRT in such cases?
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver_options.cc
File src/kudu/server/webserver_options.cc:
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver_options.cc@47
PS5, Line 47: 0.0.0.0
Does this implicitly assume IPv4 then?
Why not to keep the original semantics of an empty default string here, and bind to all available IPv4 and IPv6 interfaces if the IP config mode is 'dual'? Correspondingly, for 'ipv4' config mode this would mean '0.0.0.0', but for 'ipv6' config mode this would mean '::/0'?
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/util/net/net_util.cc
File src/kudu/util/net/net_util.cc:
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/util/net/net_util.cc@88
PS5, Line 88: Value is case-sensitive.
Why? Being case-sensitive it's not user-friendly, and many of our string flags are case-insensitive, so it's a bit off this way.
Or that's a typo? I see that ParseIPModeFlag() in PS5 uses iequals().
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/util/net/net_util.cc@115
PS5, Line 115: Status ParseIPModeFlag(const string& name,
Why to have this as a standalone function if it's only used in ValidateIPConfigMode()? Just inline it instead?
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/util/net/net_util.cc@124
PS5, Line 124: "IP config mode cannot be any value other than 'ipv4' "
: "or 'ipv6' or 'dual'. Options are case in-sensitive."
nit: replace with
can be one of 'ipv4', 'ipv6', 'dual'; case insensitive"
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/util/net/net_util.cc@365
PS5, Line 365: FLAGS_ip_config_mode == "ipv4"
Here and elsewhere where this flag is involved: since the value for the flag is case-insensitive, this way of comparison is brittle and isn't going to work if they specify it as 'IPv4' or similar. Instead, consider using the more robust approach similar to ParseTriState() and storing the result as an enum field or something like that.
Also, there is also 'sa_family_t' family parameter, why it's not used here instead?
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/util/net/net_util.cc@372
PS5, Line 372: hints.ai_family = family
Is this consistent if FLAGS_ip_config_mode == 'dual'?
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 5
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 30 Sep 2025 03:29:15 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 8: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1928/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 8
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 00:04:38 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 3:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/1870/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 3
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 26 Sep 2025 14:09:19 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 4: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1871/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 4
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 26 Sep 2025 15:41:36 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/master/mini_master-test.cc
File src/kudu/master/mini_master-test.cc:
http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/master/mini_master-test.cc@40
PS1, Line 40: WebServerIPMode
I see that we have multiple IP mode enums in this patch, can we consolidate them?
http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver-test.cc
File src/kudu/server/webserver-test.cc:
http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver-test.cc@1151
PS1, Line 1151: break;
nit: DCHECK(false); here as well as above?
http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver.cc
File src/kudu/server/webserver.cc:
http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver.cc@256
PS1, Line 256: this
nit: do we need 'this', would capturing only opts be enough?
http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver_options.h
File src/kudu/server/webserver_options.h:
http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver_options.h@28
PS1, Line 28: DUAL_STACK // TODO(araina): See if dual stack is even required
are there any further implications if dual stack is required? I mean further changes etc?
http://gerrit.cloudera.org:8080/#/c/23411/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/23411/1/thirdparty/build-definitions.sh@728
PS1, Line 728: -DUSE_IPV6"
does this mean that if we turn this compile time flag, squeasel will support ipv4 and ipv6? (meaning its not exclusive?)
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 19 Sep 2025 11:41:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 3:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1870/
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 3
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 26 Sep 2025 14:06:15 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 6:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1894/
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 6
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 01 Oct 2025 17:53:14 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 10: Verified+1 Code-Review+2
Overall looks good to me.
unrelated test failures:
release: kudu-admin-test.5
tsan: org.apache.kudu.client.TestKuduClient
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 10
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 07 Oct 2025 09:21:00 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23411
to look at the new patch set (#8).
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
KUDU-1457 [4/n] enable webserver for IPv6
This patch mainly does two things - enable webserver to make use of
IPv6 and introduce a ip config flag that can be used to choose IP
protocol for various communication channels. More details as follows:
- Add build flag (USE_IPV6) to squeasel for IPv6 support for users.
- Set appropriate bind interface for http based on webserver ip mode.
- Augment GetBoundAddresses() to enable fetching of IPv6 address.
- Introduce ip_config_mode flag that can be configured by a user if need
arises to override the default mode i.e. ipv4. One of the purposes of
this flag is to serve a hint inside various server modules like rpc,
webserver, etc to regulate the protocol used for communication.
- Set default value of --webserver_interface flag to 0.0.0.0. The value
is used as bind interface during webserver object initialisation.
- Reduce frequency of 'master address resolution to multiple addresses'
warning once a minute to reduce flooding of logs with such message
when hostname resolves to multiple addresses.
- Add parallel suite of tests to webserver-test and mini_master-test.
- Additional manual testing is also performed to ensure webserver is
correctly hosted on IPv6 interfaces and the endpoint is capable of
performing http methods.
- Fix a bug in java client net utils to ensure that input address is
correctly parsed into host and port for different IPv6 address
combinations.
- Manual testing for different combinations with servers running on
IPv4,IPv6 and Dual stack address endpoints and Kudu CLI able to
connect with servers and perform basic operations like ksck,
'perf loadgen', table list, etc. Kudu CLI also makes use of the ip
config mode flag to enforce the IP communication protocol.
Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
---
M java/kudu-client/src/main/java/org/apache/kudu/util/NetUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestNetUtil.java
M src/kudu/master/mini_master-test.cc
M src/kudu/master/mini_master.cc
M src/kudu/scripts/start_kudu.sh
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webserver_options.cc
M src/kudu/tserver/heartbeater.cc
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/net/net_util.h
M thirdparty/build-definitions.sh
13 files changed, 437 insertions(+), 107 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/23411/8
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 8
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1786/
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 1
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Sep 2025 11:37:01 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/master/mini_master-test.cc
File src/kudu/master/mini_master-test.cc:
http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/master/mini_master-test.cc@40
PS1, Line 40: MiniMasterTest
> I see that we have multiple IP mode enums in this patch, can we consolidate
enum/s are replaced by direct string gflag. Please check latest PS.
http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver-test.cc
File src/kudu/server/webserver-test.cc:
http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver-test.cc@1151
PS1, Line 1151:
> nit: DCHECK(false); here as well as above?
Not applicable anymore. Please check latest PS.
http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver.cc
File src/kudu/server/webserver.cc:
http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver.cc@256
PS1, Line 256:
> nit: do we need 'this', would capturing only opts be enough?
Not applicable anymore. Please check latest PS.
http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver_options.h
File src/kudu/server/webserver_options.h:
http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver_options.h@28
PS1, Line 28: // See those flags for documentation.
> are there any further implications if dual stack is required? I mean furthe
Not applicable anymore. Please check latest PS.
http://gerrit.cloudera.org:8080/#/c/23411/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:
http://gerrit.cloudera.org:8080/#/c/23411/1/thirdparty/build-definitions.sh@728
PS1, Line 728: $LIBEV_SOUR
> does this mean that if we turn this compile time flag, squeasel will suppor
Yes, this is not exclusive. This means adding ipv6 support on top of ipv4.
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Sun, 21 Sep 2025 19:30:43 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 7:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1900/
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 7
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 01 Oct 2025 20:01:20 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 9: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1934/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 9
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 15:41:53 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 7: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1900/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 7
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 01 Oct 2025 21:43:10 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 9:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1934/
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 9
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 14:10:31 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
KUDU-1457 [4/n] enable webserver for IPv6
This patch mainly does two things - enable webserver to make use of
IPv6 and introduce a ip config flag that can be used to choose IP
protocol for various communication channels. More details as follows:
- Add build flag (USE_IPV6) to squeasel for IPv6 support for users.
- Set appropriate bind interface for http based on webserver ip mode.
- Augment GetBoundAddresses() to enable fetching of IPv6 address.
- Introduce ip_config_mode flag that can be configured by a user if need
arises to override the default mode i.e. ipv4. One of the purposes of
this flag is to serve a hint inside various server modules like rpc,
webserver, etc to regulate the protocol used for communication.
- Set default value of --webserver_interface flag to 0.0.0.0. The value
is used as bind interface during webserver object initialisation.
- Reduce frequency of 'master address resolution to multiple addresses'
warning once a minute to reduce flooding of logs with such message
when hostname resolves to multiple addresses.
- Add parallel suite of tests to webserver-test and mini_master-test.
- Additional manual testing is also performed to ensure webserver is
correctly hosted on IPv6 interfaces and the endpoint is capable of
performing http methods.
- Fix a bug in java client net utils to ensure that input address is
correctly parsed into host and port for different IPv6 address
combinations.
- Manual testing for different combinations with servers running on
IPv4,IPv6 and Dual stack address endpoints and Kudu CLI able to
connect with servers and perform basic operations like ksck,
'perf loadgen', table list, etc. Kudu CLI also makes use of the ip
config mode flag to enforce the IP communication protocol.
Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Reviewed-on: http://gerrit.cloudera.org:8080/23411
Reviewed-by: Marton Greber <gr...@gmail.com>
Tested-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/util/NetUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestNetUtil.java
M src/kudu/master/mini_master-test.cc
M src/kudu/master/mini_master.cc
M src/kudu/scripts/start_kudu.sh
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webserver_options.cc
M src/kudu/tserver/heartbeater.cc
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/net/net_util.h
M thirdparty/build-definitions.sh
13 files changed, 433 insertions(+), 107 deletions(-)
Approvals:
Marton Greber: Looks good to me, approved; Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 11
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 8:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1928/
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 8
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Thu, 02 Oct 2025 22:09:18 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 10: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1942/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 10
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 22:38:19 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 5:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1890/
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 5
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 29 Sep 2025 21:03:05 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1828/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Sun, 21 Sep 2025 21:00:50 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 2:
(1 comment)
Looks good from a functionality point of view. I just favour clean enums if it is possible.
Let me know what you think about my comment, whether you think that is feasible.
Thanks for working on this Ashwani!
http://gerrit.cloudera.org:8080/#/c/23411/2/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:
http://gerrit.cloudera.org:8080/#/c/23411/2/src/kudu/server/server_base.cc@620
PS2, Line 620: static bool ValidateIPConfigMode() {
: return FLAGS_ip_config_mode == "ipv4" ||
: FLAGS_ip_config_mode == "ipv6" ||
: FLAGS_ip_config_mode == "dual";
: }
: GROUP_FLAG_VALIDATOR(ip_config_mode, ValidateIPConfigMode);
I’ve looked at server_base, and there seems to be a pattern for such validators: first parse (e.g., ParseTriStateFlag), then write a getter/validator that parses and returns the value.
This way, you could also log any errors.
Creating an enum here would also make things more robust. I know that in the previous revision you had enums (maybe I didn’t phrase my point clearly). My concern was that throughout this patch, once you parse the flag and create an enum, we should consistently use that enum everywhere, instead of defining other, conceptually similar enums. Sorry if I caused confusion.
I’m also not entirely sure how things are included. For example, if you have a parser and validator in server_base, could that be wired up for all other places? (Maybe via a standalone header?)
Let me know what you think.
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 22 Sep 2025 10:18:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has removed a vote on this change.
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 10
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver_options.cc
File src/kudu/server/webserver_options.cc:
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver_options.cc@47
PS5, Line 47: 0.0.0.0
> I am thinking from different perspective though: Default value for --ip_config_mode is ipv4, default for these two flags is set to INADDR_ANY (any address in ipv4 notation). That kind of fits the bill here.
Right, but this is now both IPv4 and IPv6. OK, this might be addressed in a follow-up changelist, maybe.
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 10
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 07 Oct 2025 13:37:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 5: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1890/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 5
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Mon, 29 Sep 2025 22:45:25 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 6: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1894/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 6
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Wed, 01 Oct 2025 19:15:34 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 5:
(20 comments)
Thank you, Alexey, for providing the feedback!
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/master/mini_master-test.cc
File src/kudu/master/mini_master-test.cc:
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/master/mini_master-test.cc@40
PS5, Line 40: class MiniMasterTest : public KuduTest,
: public ::testing::WithParamInterface<std::string> {
: protected:
: static std::string get_host() {
: FLAGS_ip_config_mode = GetParam();
: if (FLAGS_ip_config_mode == "ipv6") {
: return "::1";
: }
: return "127.0.0.1";
: }
: };
:
: // This is used to run all parameterized tests with different IP modes.
: INSTANTIATE_TEST_SUITE_P(Parameters, MiniMasterTest,
: testing::Values("ipv4", "ipv6"));
> Shouldn't there be coverage for the 'dual' mode here as well?
Same reason here as well. If a test had covered two distinct cases i.e.
1. Using loopback address i.e. 127.0.0.1
2. Using unspecified address i.e. 0.0.0.0
In such a test, it would make sense to have two more addresses covered as well i.e. "::1" for ipv6 mode and "::" for dual mode.
There is no reason that these tests won't run for dual mode unless there is some specific ip based communication happening that considers just the ip address we set here. Given similar conditions on a node, if a bind to ::1 works, chances are highly likely that bind to :: works as well.
If you still feel that dual mode needs to be covered, I don't mind adding.
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/master/mini_master.cc
File src/kudu/master/mini_master.cc:
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/master/mini_master.cc@70
PS5, Line 70: "[" + web_bind_addr.host() + "]"
> Shouldn't this be somehow encapsulated into HostPort or just a stand-alone
This is just one time usage here. Even though similar sort manipulation is being done in Restart() below but that relies on ip family saved in bound_http_ object member rather than a flag.
I guess both could simply rely on the flag i.e. FLAGS_ip_config_mode.
Let me see if that is possible.
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc
File src/kudu/server/webserver-test.cc:
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@188
PS5, Line 188: "ipv4", "dual"
> Why 'ipv6' is omitted? Could you at least add a comment about the reason?
The idea is to have a parallel and corresponding test for an existing scenario in ipv6/dual mode.
For example, if a test has requirement to bind to a any/unspecified ip address (0.0.0.0), it would have a corresponding test in dual mode that binds with IN6ADDR_ANY_INIT i.e. :: which is its equivalent in IPv6.
Similarly, if there is a test where loopback address (127.0.0.1) is used for binding, it would have equivalent as ::1 in IPv6.
In theory, we could have all three modes for all the tests, but it would not serve much purpose. If there was need to have a test run for both unspecified address or loopback address, it would have been done in IPv4 as well but it isn't.
Tests using WebserverAdvertisedAddressesTest have specified addresses, so two modes are applicable i.e. ipv4 and ipv6.
Similarly, for rest of the tests, unspecified address is being used so ipv4 and dual modes become applicable.
Theoretically, we could add all three modes but that may not add much value because the idea is to ensure webserver is initialised to a given address in specific scenarios and that is being achieved by running those test for mix of all three modes as applicable.
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@288
PS5, Line 288: "ipv4", "dual"
> ditto regarding the omitted 'ipv6'
ditto explanation from above
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@299
PS5, Line 299: "ipv4", "dual"
> ditto regarding the omitted 'ipv6'
ditto explanation from above
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@425
PS5, Line 425: ipv4", "dual
> ditto regarding the omitted 'ipv6'
ditto explanation from above
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@526
PS5, Line 526: pv4", "dual
> ditto regarding the omitted 'ipv6'
ditto explanation from above
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@539
PS5, Line 539: ipv4", "dual
> ditto regarding the omitted 'ipv6'
ditto explanation from above
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@744
PS5, Line 744: ipv4", "dual
> ditto regarding the omitted 'ipv6'
ditto explanation from above
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@753
PS5, Line 753: ipv4", "dual
> ditto regarding the omitted 'ipv6'
ditto explanation from above
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@830
PS5, Line 830: "ipv4", "dual")
> ditto regarding the omitted 'ipv6'
ditto explanation from above
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@893
PS5, Line 893: "ipv4", "dual"
> ditto regarding the omitted 'ipv6'
ditto explanation from above
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@994
PS5, Line 994: "127.0.0.1"
> nit: why not to use expected_advertised_host_ here as well?
Done
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@1017
PS5, Line 1017: CHECK(false)
> nit: would calling FAIL() and returning an empty string fit here, or you ex
I am not really keen on crashing with SIGABRT.
Does FAIL() have any variant that returns a string? I couldn't find any.
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver_options.cc
File src/kudu/server/webserver_options.cc:
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver_options.cc@47
PS5, Line 47: 0.0.0.0
> Does this implicitly assume IPv4 then?
This aligns with --rpc_bind_addresses that is also set to default 'unspecified' address. The default mode for ip_config_mode is IPv4 so bind addresses (for both rpc and webserver) is also default to IPv4 unspecified address.
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/util/net/net_util.cc
File src/kudu/util/net/net_util.cc:
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/util/net/net_util.cc@88
PS5, Line 88: Value is case-sensitive.
> Why? Being case-sensitive it's not user-friendly, and many of our string f
That's a type. Fixed now.
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/util/net/net_util.cc@115
PS5, Line 115: Status ParseIPModeFlag(const string& name,
> Why to have this as a standalone function if it's only used in ValidateIPCo
Done
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/util/net/net_util.cc@124
PS5, Line 124: "IP config mode cannot be any value other than 'ipv4' "
: "or 'ipv6' or 'dual'. Options are case in-sensitive."
> nit: replace with
Done
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/util/net/net_util.cc@365
PS5, Line 365: FLAGS_ip_config_mode == "ipv4"
> Here and elsewhere where this flag is involved: since the value for the fla
That is a miss from my side. I think I wanted to use helper function but somehow missed doing that here.
Marton also suggested something similar about enum usage. I guess now that value is case insensitive, the need to have enum based approach makes sense.
'family' has default value set to AF_UNSPEC.
Maybe remove the need of 'family' altogether and simply rely on the flag is something that can be done. Just like it is done in GetFQDN. I will check and get back on this.
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/util/net/net_util.cc@372
PS5, Line 372: hints.ai_family = family
> Is this consistent if FLAGS_ip_config_mode == 'dual'?
Yes, the default value for family is AF_UNSPEC which is applicable to dual mode.
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 5
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Tue, 30 Sep 2025 13:51:47 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23411/2/src/kudu/server/server_base.cc
File src/kudu/server/server_base.cc:
http://gerrit.cloudera.org:8080/#/c/23411/2/src/kudu/server/server_base.cc@620
PS2, Line 620: static bool ValidateIPConfigMode() {
: return FLAGS_ip_config_mode == "ipv4" ||
: FLAGS_ip_config_mode == "ipv6" ||
: FLAGS_ip_config_mode == "dual";
: }
: GROUP_FLAG_VALIDATOR(ip_config_mode, ValidateIPConfigMode);
> I’ve looked at server_base, and there seems to be a pattern for such valida
Thanks for the inputs.
I don't think enums are required anymore in the latest PS. At this point, there are a couple of places (mini master and webserver) only where flag value is checked. Adding enums will add more code and that will still enum checks. As far as validation is concerned, I have added error log to the validation function in case user enters incorrect option. I see a bunch of other places in code, where string based flags have no enum counterpart and validation is done in default validator function. Please take a look at latest PS. If you still think enum would make sense and why, I don't mind add one.
Also, flag and its validator is moved to net_util.cc now. It seems more appropriate to be placed under net util.
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 26 Sep 2025 14:05:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23411
to look at the new patch set (#9).
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
KUDU-1457 [4/n] enable webserver for IPv6
This patch mainly does two things - enable webserver to make use of
IPv6 and introduce a ip config flag that can be used to choose IP
protocol for various communication channels. More details as follows:
- Add build flag (USE_IPV6) to squeasel for IPv6 support for users.
- Set appropriate bind interface for http based on webserver ip mode.
- Augment GetBoundAddresses() to enable fetching of IPv6 address.
- Introduce ip_config_mode flag that can be configured by a user if need
arises to override the default mode i.e. ipv4. One of the purposes of
this flag is to serve a hint inside various server modules like rpc,
webserver, etc to regulate the protocol used for communication.
- Set default value of --webserver_interface flag to 0.0.0.0. The value
is used as bind interface during webserver object initialisation.
- Reduce frequency of 'master address resolution to multiple addresses'
warning once a minute to reduce flooding of logs with such message
when hostname resolves to multiple addresses.
- Add parallel suite of tests to webserver-test and mini_master-test.
- Additional manual testing is also performed to ensure webserver is
correctly hosted on IPv6 interfaces and the endpoint is capable of
performing http methods.
- Fix a bug in java client net utils to ensure that input address is
correctly parsed into host and port for different IPv6 address
combinations.
- Manual testing for different combinations with servers running on
IPv4,IPv6 and Dual stack address endpoints and Kudu CLI able to
connect with servers and perform basic operations like ksck,
'perf loadgen', table list, etc. Kudu CLI also makes use of the ip
config mode flag to enforce the IP communication protocol.
Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
---
M java/kudu-client/src/main/java/org/apache/kudu/util/NetUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/util/TestNetUtil.java
M src/kudu/master/mini_master-test.cc
M src/kudu/master/mini_master.cc
M src/kudu/scripts/start_kudu.sh
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webserver_options.cc
M src/kudu/tserver/heartbeater.cc
M src/kudu/util/net/net_util-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/net/net_util.h
M thirdparty/build-definitions.sh
13 files changed, 433 insertions(+), 107 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/23411/9
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 9
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 8:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc
File src/kudu/server/webserver-test.cc:
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@188
PS5, Line 188: verTest {
> Thanks a lot for the explanation.
For now, 'ipv4' and 'dual' should be good enough. I am planning to add more tests but that will happen later.
Current test coverage is to ensure basic functionality is working fine.
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver-test.cc@1017
PS5, Line 1017:
> I guess it would require changing the signature of this method to start usi
Changing the signature would involve more cycles and I have other priority work that needs urgent attention. Would prefer to keep it as-is.
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver_options.cc
File src/kudu/server/webserver_options.cc:
http://gerrit.cloudera.org:8080/#/c/23411/5/src/kudu/server/webserver_options.cc@47
PS5, Line 47: 0.0.0.0
> > This aligns with --rpc_bind_addresses that is also set to default 'unspec
I am thinking from different perspective though: Default value for --ip_config_mode is ipv4, default for these two flags is set to INADDR_ANY (any address in ipv4 notation). That kind of fits the bill here.
If you are not too keen on moving back the default values to empty string, I would like to keep this as is.
Moving back to empty string for both flags would require more cycles at this point and I don't think I have any given the list of other pending items.
Unless you see an issue here that needs to be fixed in any case, let's keep this as-is.
http://gerrit.cloudera.org:8080/#/c/23411/8/src/kudu/util/net/net_util.cc
File src/kudu/util/net/net_util.cc:
http://gerrit.cloudera.org:8080/#/c/23411/8/src/kudu/util/net/net_util.cc@170
PS8, Line 170: Status ParseIPModeFlag(const char* flag_name,
: const string& flag_value,
: IPMode* mode) {
: if (iequals(flag_value, "ipv4")) {
: *mode = IPMode::IPV4;
: } else if (iequals(flag_value, "ipv6")) {
: *mode = IPMode::IPV6;
: } else if (iequals(flag_value, "dual")) {
: *mode = IPMode::DUAL;
: } else {
: return Status::InvalidArgument(
: Substitute("$0: invalid value for flag --$1, can be one of "
: "'ipv4', 'ipv6', 'dual'; case insensitive",
: flag_value, flag_name));
: }
: return Status::OK();
: }
> Do we expect to the ip_config_mode flag change in runtime? If not, conside
It is not expected to change at runtime. I had thought about using std::once or something similar but that puts a restriction on tests that extensively change the flag value to test out different modes.
I guess we can make tests run with std:once usage and have some sort of reset logic that resets the value in order for tests to be able to set them again. This requires more time to get it right.
For now, I would like to make a note of this and address this later.
This gets called from validator function as well which does validation before setting the value. So at least input value needs to be passed here. Since this is used for just one flag i.e. ip_config_mode, I have removed the first argument i.e. flag_name
http://gerrit.cloudera.org:8080/#/c/23411/8/src/kudu/util/net/net_util.cc@515
PS8, Line 515: if (PREDICT_FALSE(out == nullptr)) {
: return Status::InvalidArgument("null output string");
: }
> nit: usually, this is done using DCHECK() -- since the variability of the n
Makes sense. Done.
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 8
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 13:51:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1457 [4/n] enable webserver for IPv6
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1828/
--
To view, visit http://gerrit.cloudera.org:8080/23411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e
Gerrit-Change-Number: 23411
Gerrit-PatchSet: 2
Gerrit-Owner: Ashwani Raina <ar...@gmail.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Sun, 21 Sep 2025 19:29:59 +0000
Gerrit-HasComments: No