[GitHub] [pinot] swaminathanmanish commented on a diff in pull request #10324: Adding table name to create unique Kafka consumer client Ids

["swaminathanmanish (via GitHub)" <gi...@apache.org>]

swaminathanmanish commented on code in PR #10324:
URL: https://github.com/apache/pinot/pull/10324#discussion_r1119033779


##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/PartitionGroupMetadataFetcher.java:
##########
@@ -63,7 +63,8 @@ public Exception getException() {
   @Override
   public Boolean call()
       throws Exception {
-    String clientId = PartitionGroupMetadataFetcher.class.getSimpleName() + "-" + _topicName;
+    String clientId = PartitionGroupMetadataFetcher.class.getSimpleName() + "-"

Review Comment:
   Wouldn't table name itself give that uniqueness ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org