You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by kkhatua <gi...@git.apache.org> on 2017/06/19 23:42:02 UTC
[GitHub] drill pull request #856: DRILL-3640: Support JDBC Statement.setQueryTimeout(...
GitHub user kkhatua opened a pull request:
https://github.com/apache/drill/pull/856
DRILL-3640: Support JDBC Statement.setQueryTimeout(int)
Allow for queries to be cancelled if they don't complete within the stipulated time.
We submit a timeout-managing task that sleeps for the stipulated period before trying to cancel the query (JDBC Statement).
It might be worth having a similar feature as a System/Session variable so that the same can be achieved via SQLLine or REST APIs, but is beyond the scope of this JIRA's PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kkhatua/drill DRILL-3640
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/856.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #856
----
commit e3c5c0f69b8f433dd159a37557c1bc4410ba537e
Author: Kunal Khatua <kk...@maprtech.com>
Date: 2017-06-19T23:26:52Z
DRILL-3640: Support JDBC Statement.setQueryTimeout(int)
Allow for queries to be cancelled if they don't complete within the stipulated time.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #856: DRILL-3640: Support JDBC Statement.setQueryTimeout(int)
Posted by kkhatua <gi...@git.apache.org>.
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/856
@ppadma / @parthchandra ... can you review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #856: DRILL-3640: Support JDBC Statement.setQueryTimeout(...
Posted by kkhatua <gi...@git.apache.org>.
Github user kkhatua closed the pull request at:
https://github.com/apache/drill/pull/856
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #856: DRILL-3640: Support JDBC Statement.setQueryTimeout(int)
Posted by kkhatua <gi...@git.apache.org>.
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/856
Existing negative Unit tests are failing. Look like we never had proper unit tests. Will add them and update the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---