You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "fatima-qaisar (via GitHub)" <gi...@apache.org> on 2026/08/12 09:43:50 UTC
[PR] Fix subsection heading levels for nested subsections (h5/h6) [tomcat]
fatima-qaisar opened a new pull request, #1039:
URL: https://github.com/apache/tomcat/pull/1039
Fix the XSLT template for nested `<subsection>` elements so that the
generated heading level reflects the nesting depth.
Previously, every `<subsection>` was rendered as `<h4>`, regardless of
whether it was nested inside another subsection.
The template now generates:
- `<h4>` for subsections directly under a `<section>`
- `<h5>` for subsections nested one level deep
- `<h6>` for subsections nested two or more levels deep
Testing:
- `ant build-docs` - confirmed the generated documentation builds
successfully and the headings are rendered correctly in the output
- Verified visually with a local test XML document containing nested
subsections; the generated headings now use the expected h4 → h5 → h6
hierarchy.
Screenshots attached showing the correct rendering in both:
- an actual Tomcat documentation page
<img width="851" height="512" alt="test" src="https://github.com/user-attachments/assets/9ea1a7f8-14fc-4e61-89fa-cb32435bea5e" />
- the local nested-subsection test XML output
<img width="570" height="619" alt="nesting test" src="https://github.com/user-attachments/assets/c2522558-f325-4d08-9c72-eb712b45224f" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Fix subsection heading levels for nested subsections (h5/h6) [tomcat]
Posted by "ChristopherSchultz (via GitHub)" <gi...@apache.org>.
ChristopherSchultz merged PR #1039:
URL: https://github.com/apache/tomcat/pull/1039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Fix subsection heading levels for nested subsections (h5/h6) [tomcat]
Posted by "ChristopherSchultz (via GitHub)" <gi...@apache.org>.
ChristopherSchultz commented on PR #1039:
URL: https://github.com/apache/tomcat/pull/1039#issuecomment-5284230043
Even though we don't actually have any sub-subsections anywhere in our documentation, this does resolve a 13-year-old TODO. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [PR] Fix subsection heading levels for nested subsections (h5/h6) [tomcat]
Posted by "fatima-qaisar (via GitHub)" <gi...@apache.org>.
fatima-qaisar commented on PR #1039:
URL: https://github.com/apache/tomcat/pull/1039#issuecomment-5289782575
There was ONE instance of it in the User Guide. And at least this was interesting to resolve :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org