You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/10/07 20:06:11 UTC
Review Request 26420: Use RBT by default and correctly determine if
version is >= 0.6
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26420/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
Use RBT by default and correctly determine if version is >= 0.6
Diffs
-----
support/post-reviews.py 7b42d8ef8652fb0aac2855eaf8269ed317949784
Diff: https://reviews.apache.org/r/26420/diff/
Testing
-------
submitted this review
there's still an issue with rbt >= 0.6 and external diff tools, but this PR should help that: https://github.com/reviewboard/rbtools/pull/42
Thanks,
Dominic Hamon
Re: Review Request 26420: Use RBT by default and correctly determine
if version is >= 0.6
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26420/#review57891
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Oct. 22, 2014, 8:25 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26420/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 8:25 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1969
> https://issues.apache.org/jira/browse/MESOS-1969
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Use RBT by default and correctly determine if version is >= 0.6
>
>
> Diffs
> -----
>
> support/post-reviews.py 7b42d8ef8652fb0aac2855eaf8269ed317949784
>
> Diff: https://reviews.apache.org/r/26420/diff/
>
>
> Testing
> -------
>
> submitted this review
>
> there's still an issue with rbt >= 0.6 and external diff tools, but this PR should help that: https://github.com/reviewboard/rbtools/pull/42
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 26420: Use RBT by default and correctly determine
if version is >= 0.6
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26420/
-----------------------------------------------------------
(Updated Oct. 22, 2014, 1:25 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
added jira reference
Bugs: MESOS-1969
https://issues.apache.org/jira/browse/MESOS-1969
Repository: mesos-git
Description
-------
Use RBT by default and correctly determine if version is >= 0.6
Diffs
-----
support/post-reviews.py 7b42d8ef8652fb0aac2855eaf8269ed317949784
Diff: https://reviews.apache.org/r/26420/diff/
Testing
-------
submitted this review
there's still an issue with rbt >= 0.6 and external diff tools, but this PR should help that: https://github.com/reviewboard/rbtools/pull/42
Thanks,
Dominic Hamon
Re: Review Request 26420: Use RBT by default and correctly determine
if version is >= 0.6
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26420/#review55701
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26420]
All tests passed.
- Mesos ReviewBot
On Oct. 7, 2014, 6:06 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26420/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2014, 6:06 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Use RBT by default and correctly determine if version is >= 0.6
>
>
> Diffs
> -----
>
> support/post-reviews.py 7b42d8ef8652fb0aac2855eaf8269ed317949784
>
> Diff: https://reviews.apache.org/r/26420/diff/
>
>
> Testing
> -------
>
> submitted this review
>
> there's still an issue with rbt >= 0.6 and external diff tools, but this PR should help that: https://github.com/reviewboard/rbtools/pull/42
>
>
> Thanks,
>
> Dominic Hamon
>
>