You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (JIRA)" <ji...@apache.org> on 2011/08/31 18:33:09 UTC
[jira] [Created] (HBASE-4311)
HBaseTestingUtility.createMultiRegions generates table that fails in hbck.
HBaseTestingUtility.createMultiRegions generates table that fails in hbck.
--------------------------------------------------------------------------
Key: HBASE-4311
URL: https://issues.apache.org/jira/browse/HBASE-4311
Project: HBase
Issue Type: Bug
Reporter: Jonathan Hsieh
Assignee: Jonathan Hsieh
When refactoring TestHBaseFsckRepair to add more hbck test cases, I noticed that HBaseTestingUtility.createMultiRegions uses an existing table with empty region, adds more regions, and then attempts to remove the region. The region remains in meta and is causes hbck to report at inconsistency. Ideally these test table generation utility functions should generate clean tables.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4311)
HBaseTestingUtility.createMultiRegions generates table that fails in hbck.
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097011#comment-13097011 ]
Jonathan Hsieh commented on HBASE-4311:
---------------------------------------
Thanks for the pointer, I'll update table creation in HBASE-4313's refactor of hbck tests. The existing version and the current dev version of the hbck tests does a somewhat hacky cleanup to make the table clean before messing it up again.
> HBaseTestingUtility.createMultiRegions generates table that fails in hbck.
> --------------------------------------------------------------------------
>
> Key: HBASE-4311
> URL: https://issues.apache.org/jira/browse/HBASE-4311
> Project: HBase
> Issue Type: Bug
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> When refactoring TestHBaseFsckRepair to add more hbck test cases, I noticed that HBaseTestingUtility.createMultiRegions uses an existing table with empty region, adds more regions, and then attempts to remove the region. The region remains in meta and is causes hbck to report at inconsistency. Ideally these test table generation utility functions should generate clean tables.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4311)
HBaseTestingUtility.createMultiRegions generates table that fails in hbck.
Posted by "Jonathan Hsieh (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh resolved HBASE-4311.
-----------------------------------
Resolution: Won't Fix
Used other mechanisms to create tables for hbck / HBASE-5128. Might be better to create new issue to remove or deprecate these methods (if this hasn't happened yet).
> HBaseTestingUtility.createMultiRegions generates table that fails in hbck.
> --------------------------------------------------------------------------
>
> Key: HBASE-4311
> URL: https://issues.apache.org/jira/browse/HBASE-4311
> Project: HBase
> Issue Type: Bug
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> When refactoring TestHBaseFsckRepair to add more hbck test cases, I noticed that HBaseTestingUtility.createMultiRegions uses an existing table with empty region, adds more regions, and then attempts to remove the region. The region remains in meta and is causes hbck to report at inconsistency. Ideally these test table generation utility functions should generate clean tables.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4311)
HBaseTestingUtility.createMultiRegions generates table that fails in hbck.
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095336#comment-13095336 ]
Jonathan Hsieh commented on HBASE-4311:
---------------------------------------
The description is slightly wrong. The entry is removed from meta but it may be assigned and its hdfs hfile stuff is still present which causes hbck to complain.
> HBaseTestingUtility.createMultiRegions generates table that fails in hbck.
> --------------------------------------------------------------------------
>
> Key: HBASE-4311
> URL: https://issues.apache.org/jira/browse/HBASE-4311
> Project: HBase
> Issue Type: Bug
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> When refactoring TestHBaseFsckRepair to add more hbck test cases, I noticed that HBaseTestingUtility.createMultiRegions uses an existing table with empty region, adds more regions, and then attempts to remove the region. The region remains in meta and is causes hbck to report at inconsistency. Ideally these test table generation utility functions should generate clean tables.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4311)
HBaseTestingUtility.createMultiRegions generates table that fails in hbck.
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096965#comment-13096965 ]
stack commented on HBASE-4311:
------------------------------
I agree we should create hbck clean tables.
FYI, the gymnastics being done in createMultiRegion precedes the createTable that took a list of regions. In other words, I don't think we need do it this way any more. Could just do http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/HBaseAdmin.html#createTable(org.apache.hadoop.hbase.HTableDescriptor, byte[][]) I believe.
(You might not be able to do the above w/ the createTableWithLegacy calls though)
> HBaseTestingUtility.createMultiRegions generates table that fails in hbck.
> --------------------------------------------------------------------------
>
> Key: HBASE-4311
> URL: https://issues.apache.org/jira/browse/HBASE-4311
> Project: HBase
> Issue Type: Bug
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> When refactoring TestHBaseFsckRepair to add more hbck test cases, I noticed that HBaseTestingUtility.createMultiRegions uses an existing table with empty region, adds more regions, and then attempts to remove the region. The region remains in meta and is causes hbck to report at inconsistency. Ideally these test table generation utility functions should generate clean tables.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira