You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ayushtkn (via GitHub)" <gi...@apache.org> on 2023/04/20 21:04:28 UTC

[GitHub] [hadoop] ayushtkn commented on a diff in pull request #5438: HDFS-16936. Add baseDir option in NNThroughputBenchmark

ayushtkn commented on code in PR #5438:
URL: https://github.com/apache/hadoop/pull/5438#discussion_r1173088657


##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java:
##########
@@ -288,7 +286,7 @@ void cleanUp() throws IOException {
       clientProto.setSafeMode(HdfsConstants.SafeModeAction.SAFEMODE_LEAVE,
           false);
       if(!keepResults)
-        clientProto.delete(getBaseDir(), true);
+        clientProto.delete(getWorkDir(), true);

Review Comment:
   Why workdir now?



##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java:
##########
@@ -228,7 +227,6 @@ abstract class OperationStatsBase {
     abstract void printResults();
 
     OperationStatsBase() {
-      baseDir = BASE_DIR_NAME + "/" + getOpName();

Review Comment:
   should have been getBaseDir() + "/" + getOpName();?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org