You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by gi...@apache.org on 2026/10/05 04:23:14 UTC
(datafusion-comet) branch gh-readonly-queue/main/pr-6644-33f21da181c14df7fa3e6a3104c3d7215810147e created (now 93ce5c3471)
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a change to branch gh-readonly-queue/main/pr-6644-33f21da181c14df7fa3e6a3104c3d7215810147e
in repository https://gitbox.apache.org/repos/asf/datafusion-comet.git
at 93ce5c3471 test: use the renamed native write flag in the Iceberg 1.11 WAP-branch suite (#6644)
This branch includes the following new commits:
new 93ce5c3471 test: use the renamed native write flag in the Iceberg 1.11 WAP-branch suite (#6644)
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org
(datafusion-comet) 01/01: test: use the renamed native write flag in the Iceberg 1.11 WAP-branch suite (#6644)
Posted by gi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-6644-33f21da181c14df7fa3e6a3104c3d7215810147e
in repository https://gitbox.apache.org/repos/asf/datafusion-comet.git
commit 93ce5c3471dbd89aa5cd5f6f9e26df27adab6a8a
Author: Andy Grove <ag...@apache.org>
AuthorDate: Mon Oct 5 04:22:55 2026 +0000
test: use the renamed native write flag in the Iceberg 1.11 WAP-branch suite (#6644)
#6494 renamed spark.comet.iceberg.write.enabled to
spark.comet.write.iceberg.enabled. #6415 merged after it and added a
Comet session to TestPartitionedWritesToWapBranch in the Iceberg 1.11.0
diff that still sets the old key. Comet does not read that key, so the
suite ran without the native Iceberg writer.
Regenerate the diff with the new key. The only other change is the
index line of that file.
---
dev/diffs/iceberg/1.11.0.diff | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dev/diffs/iceberg/1.11.0.diff b/dev/diffs/iceberg/1.11.0.diff
index e2b8e608b0..0096fadaad 100644
--- a/dev/diffs/iceberg/1.11.0.diff
+++ b/dev/diffs/iceberg/1.11.0.diff
@@ -75,7 +75,7 @@ index b5d6415763..0763a723d3 100644
protected void createTableWithDeleteGranularity(
diff --git a/spark/v4.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestPartitionedWritesToWapBranch.java b/spark/v4.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestPartitionedWritesToWapBranch.java
-index af065451ab..ec7cdc2edb 100644
+index af065451ab..68e6dcadaf 100644
--- a/spark/v4.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestPartitionedWritesToWapBranch.java
+++ b/spark/v4.1/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestPartitionedWritesToWapBranch.java
@@ -69,6 +69,17 @@ public class TestPartitionedWritesToWapBranch extends PartitionedWritesTestBase
@@ -89,7 +89,7 @@ index af065451ab..ec7cdc2edb 100644
+ .config("spark.comet.explainFallback.enabled", "true")
+ .config("spark.comet.scan.icebergNative.enabled", "true")
+ .config("spark.comet.write.iceberg.splitOperator.enabled", "true")
-+ .config("spark.comet.iceberg.write.enabled", "true")
++ .config("spark.comet.write.iceberg.enabled", "true")
+ .config("spark.comet.exec.localTableScan.enabled", "true")
+ .config("spark.memory.offHeap.enabled", "true")
+ .config("spark.memory.offHeap.size", "10g")
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org