[jira] [Commented] (AIRFLOW-2826) Add hook for Google Cloud KMS

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-2826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566064#comment-16566064 ] 

ASF GitHub Bot commented on AIRFLOW-2826:
-----------------------------------------

jakahn opened a new pull request #3677: [AIRFLOW-2826] Add GoogleCloudKMSHook
URL: https://github.com/apache/incubator-airflow/pull/3677
 
 
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title
     - https://issues.apache.org/jira/browse/AIRFLOW-2826
   
   ### Description
   
   - [X] Here are some details about my PR (no UI changes):
      - Adds a hook enabling encryption and decryption through Google Cloud KMS. Both operations also support the use of the "additionalAuthenticatedData" field for the requests.
      - This hook is also added in anticipation of integration with future work on [AIRFLOW-2062](https://issues.apache.org/jira/browse/AIRFLOW-2062).
   
   ### Tests
   
   - [X] My PR adds the following unit tests:
      - `tests/contrib/hooks/test_gcp_kms_hook.py`
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [X] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add hook for Google Cloud KMS
> -----------------------------
>
>                 Key: AIRFLOW-2826
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2826
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: hooks
>            Reporter: Jasper Kahn
>            Assignee: Jasper Kahn
>            Priority: Minor
>              Labels: features
>
> Add a hook to support interacting with Google Cloud KMS. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)