You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by er...@apache.org on 2013/01/08 13:56:43 UTC
svn commit: r1430264 - in /flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal: as/codegen/TestGlobalConstants.java js/codegen/goog/TestGoogFieldMembers.java js/codegen/goog/TestGoogGlobalConstants.java

Author: erikdebruin
Date: Tue Jan  8 12:56:42 2013
New Revision: 1430264

URL: http://svn.apache.org/viewvc?rev=1430264&view=rev
Log:
- tests now pass for '-Infinity'
- added a test for the assignment of a negative number to a var (wrote it while looking for cause of the -Infinity bug)

Modified:
    flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalConstants.java
    flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFieldMembers.java
    flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalConstants.java

Modified: flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalConstants.java
URL: http://svn.apache.org/viewvc/flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalConstants.java?rev=1430264&r1=1430263&r2=1430264&view=diff
==============================================================================
--- flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalConstants.java (original)
+++ flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/as/codegen/TestGlobalConstants.java Tue Jan  8 12:56:42 2013
@@ -21,7 +21,6 @@ package org.apache.flex.compiler.interna
 
 import org.apache.flex.compiler.tree.as.IFileNode;
 import org.apache.flex.compiler.tree.as.IVariableNode;
-import org.junit.Ignore;
 import org.junit.Test;
 
 /**
@@ -37,11 +36,9 @@ public class TestGlobalConstants extends
         assertOut("var a:Number = Infinity");
     }
 
-    @Ignore
     @Test
     public void testNegativeInfinity()
     {
-    	// TODO (erikdebruin) Mike, why is this failing?
         IVariableNode node = getField("var a:Number = -Infinity;");
         visitor.visitVariable(node);
         assertOut("var a:Number = -Infinity");

Modified: flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFieldMembers.java
URL: http://svn.apache.org/viewvc/flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFieldMembers.java?rev=1430264&r1=1430263&r2=1430264&view=diff
==============================================================================
--- flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFieldMembers.java (original)
+++ flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogFieldMembers.java Tue Jan  8 12:56:42 2013
@@ -69,6 +69,14 @@ public class TestGoogFieldMembers extend
         assertOut("/**\n * @type {number}\n */\nA.prototype.foo = 420");
     }
 
+    @Test
+    public void testField_withTypeValue_Negative()
+    {
+        IVariableNode node = getField("var foo:int = -420;");
+        visitor.visitVariable(node);
+        assertOut("/**\n * @type {number}\n */\nA.prototype.foo = -420");
+    }
+
     @Override
     @Test
     public void testField_withNamespaceTypeValue()

Modified: flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalConstants.java
URL: http://svn.apache.org/viewvc/flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalConstants.java?rev=1430264&r1=1430263&r2=1430264&view=diff
==============================================================================
--- flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalConstants.java (original)
+++ flex/whiteboard/mschmalle/falconjx/compiler.jx.tests/src/org/apache/flex/compiler/internal/js/codegen/goog/TestGoogGlobalConstants.java Tue Jan  8 12:56:42 2013
@@ -24,7 +24,6 @@ import org.apache.flex.compiler.internal
 import org.apache.flex.compiler.internal.js.codegen.JSSharedData;
 import org.apache.flex.compiler.internal.js.driver.goog.GoogBackend;
 import org.apache.flex.compiler.tree.as.IVariableNode;
-import org.junit.Ignore;
 import org.junit.Test;
 
 /**
@@ -43,7 +42,6 @@ public class TestGoogGlobalConstants ext
         assertOut("A.prototype.a = Infinity");
     }
 
-    @Ignore
     @Override
     @Test
     public void testNegativeInfinity()