You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zsxwing <gi...@git.apache.org> on 2017/11/16 19:02:16 UTC
[GitHub] spark pull request #19768: [SPARK-22535][PYSPARK] Sleep before killing the p...
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/19768
[SPARK-22535][PYSPARK] Sleep before killing the python worker in PythRunner.MonitorThread (branch-2.2)
## What changes were proposed in this pull request?
Backport #19762 to 2.2
## How was this patch tested?
Jenkins
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark SPARK-22535-2.2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19768.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19768
----
commit 087d2273b58d07fbc30948001d69225e4a7c7aeb
Author: Shixiong Zhu <zs...@gmail.com>
Date: 2017-11-16T18:59:42Z
[SPARK-22535][PYSPARK] Sleep before killing the python worker in PythonRunner.MonitorThread
`PythonRunner.MonitorThread` should give the task a little time to finish before forcibly killing the python worker. This will reduce the chance of the race condition a lot. I also improved the log a bit\
to find out the task to blame when it's stuck.
Jenkins
Author: Shixiong Zhu <zs...@gmail.com>
Closes #19762 from zsxwing/SPARK-22535.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19768: [SPARK-22535][PYSPARK] Sleep before killing the python w...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19768
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83945/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19768: [SPARK-22535][PYSPARK] Sleep before killing the python w...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19768
**[Test build #83945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83945/testReport)** for PR 19768 at commit [`087d227`](https://github.com/apache/spark/commit/087d2273b58d07fbc30948001d69225e4a7c7aeb).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19768: [SPARK-22535][PYSPARK] Sleep before killing the python w...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/19768
cc @ueshin
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19768: [SPARK-22535][PYSPARK] Sleep before killing the python w...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19768
**[Test build #83945 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83945/testReport)** for PR 19768 at commit [`087d227`](https://github.com/apache/spark/commit/087d2273b58d07fbc30948001d69225e4a7c7aeb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19768: [SPARK-22535][PYSPARK] Sleep before killing the python w...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19768
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19768: [SPARK-22535][PYSPARK] Sleep before killing the python w...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/19768
Thanks! Merging to 2.2
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19768: [SPARK-22535][PYSPARK] Sleep before killing the p...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing closed the pull request at:
https://github.com/apache/spark/pull/19768
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org