You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by zsxwing <gi...@git.apache.org> on 2017/11/10 19:48:09 UTC
[GitHub] spark pull request #19718: [SPARK-19644][SQL] Clean up Scala reflection garb...
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/19718
[SPARK-19644][SQL] Clean up Scala reflection garbage after creating Encoder (branch-2.2)
## What changes were proposed in this pull request?
Backport #19687 to branch-2.2. The major difference is `cleanUpReflectionObjects` is protected by `ScalaReflectionLock.synchronized` in this PR for Scala 2.10.
## How was this patch tested?
Jenkins
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zsxwing/spark SPARK-19644-2.2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19718.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19718
----
commit 7bff354873bb236d4c2855e9247dffb89cc2f259
Author: Shixiong Zhu <zs...@gmail.com>
Date: 2017-11-10T19:27:28Z
[SPARK-19644][SQL] Clean up Scala reflection garbage after creating Encoder
Because of the memory leak issue in `scala.reflect.api.Types.TypeApi.<:<` (https://github.com/scala/bug/issues/8302), creating an encoder may leak memory.
This PR adds `cleanUpReflectionObjects` to clean up these leaking objects for methods calling `scala.reflect.api.Types.TypeApi.<:<`.
The updated unit tests.
Author: Shixiong Zhu <zs...@gmail.com>
Closes #19687 from zsxwing/SPARK-19644.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19718: [SPARK-19644][SQL] Clean up Scala reflection garbage aft...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19718
**[Test build #83702 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83702/testReport)** for PR 19718 at commit [`7bff354`](https://github.com/apache/spark/commit/7bff354873bb236d4c2855e9247dffb89cc2f259).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19718: [SPARK-19644][SQL] Clean up Scala reflection garbage aft...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/19718
cc @cloud-fan
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19718: [SPARK-19644][SQL] Clean up Scala reflection garbage aft...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19718
**[Test build #83702 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83702/testReport)** for PR 19718 at commit [`7bff354`](https://github.com/apache/spark/commit/7bff354873bb236d4c2855e9247dffb89cc2f259).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19718: [SPARK-19644][SQL] Clean up Scala reflection garbage aft...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/19718
Thanks! Merging to 2.2.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19718: [SPARK-19644][SQL] Clean up Scala reflection garb...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing closed the pull request at:
https://github.com/apache/spark/pull/19718
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19718: [SPARK-19644][SQL] Clean up Scala reflection garbage aft...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19718
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19718: [SPARK-19644][SQL] Clean up Scala reflection garbage aft...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19718
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83702/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19718: [SPARK-19644][SQL] Clean up Scala reflection garbage aft...
Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:
https://github.com/apache/spark/pull/19718
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org