You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/04 13:45:05 UTC
[GitHub] [arrow] pitrou commented on a diff in pull request #13063: MINOR: Use bundled gtest
pitrou commented on code in PR #13063:
URL: https://github.com/apache/arrow/pull/13063#discussion_r864846009
##########
dev/tasks/vcpkg-tests/cpp-build-vcpkg.bat:
##########
@@ -70,6 +70,7 @@ cmake -G "Visual Studio 16 2019" -A x64 ^
-DARROW_WITH_SNAPPY=ON ^
-DARROW_WITH_ZLIB=ON ^
-DARROW_WITH_ZSTD=ON ^
+ -DGTest_SOURCE=SYSTEM ^
Review Comment:
Hmm, how does this work on Windows? "system" would mean system-provided packages on Linux, but I don't think those exist at all on Windows.
##########
dev/tasks/vcpkg-tests/cpp-build-vcpkg.bat:
##########
@@ -70,6 +70,7 @@ cmake -G "Visual Studio 16 2019" -A x64 ^
-DARROW_WITH_SNAPPY=ON ^
-DARROW_WITH_ZLIB=ON ^
-DARROW_WITH_ZSTD=ON ^
+ -DGTest_SOURCE=SYSTEM ^
Review Comment:
cc @kou for advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org