You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "timtebeek (via GitHub)" <gi...@apache.org> on 2023/08/19 17:36:02 UTC

[GitHub] [maven-scm] timtebeek opened a new pull request, #183: [MNG-6829] Replace trimmed StringUtils#isEmpty(String) and #isNotEmpy

timtebeek opened a new pull request, #183:
URL: https://github.com/apache/maven-scm/pull/183

   Additional replacements as compared to https://github.com/apache/maven-scm/pull/169, now also replacing where the input was trimmed.
   
   @elharo would you mind having look at this one and a few to follow? I want to start this up again. :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-scm] slachiewicz commented on pull request #183: [MNG-6829] Replace trimmed StringUtils#isEmpty(String) and #isNotEmpy

Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #183:
URL: https://github.com/apache/maven-scm/pull/183#issuecomment-1685231834

   We agreed that it's not cost effective to write tools to create Jira per project with this automation 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-scm] slachiewicz merged pull request #183: [MNG-6829] Replace trimmed StringUtils#isEmpty(String) and #isNotEmpy

Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz merged PR #183:
URL: https://github.com/apache/maven-scm/pull/183


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-scm] elharo commented on pull request #183: [MNG-6829] Replace trimmed StringUtils#isEmpty(String) and #isNotEmpy

Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on PR #183:
URL: https://github.com/apache/maven-scm/pull/183#issuecomment-1685258057

   @timtebeek Just assign me as a reviewer on any PR you want me to look at. Otherwise I'm likely to miss them. Of course, it's 100% fine if someone else reviews and merges these first. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-scm] olamy commented on pull request #183: [MNG-6829] Replace trimmed StringUtils#isEmpty(String) and #isNotEmpy

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #183:
URL: https://github.com/apache/maven-scm/pull/183#issuecomment-1685250085

   > We agreed that it's not cost effective to write tools to create Jira per project with this automation
   
   Fine. but where is this agreement? Do you know if something was talked about it on a mailing list?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-scm] olamy commented on pull request #183: [MNG-6829] Replace trimmed StringUtils#isEmpty(String) and #isNotEmpy

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #183:
URL: https://github.com/apache/maven-scm/pull/183#issuecomment-1685160977

   shouldn't we have a corresponding SCM- issue rather than MNG- as it's not a core change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-scm] timtebeek commented on pull request #183: [MNG-6829] Replace trimmed StringUtils#isEmpty(String) and #isNotEmpy

Posted by "timtebeek (via GitHub)" <gi...@apache.org>.
timtebeek commented on PR #183:
URL: https://github.com/apache/maven-scm/pull/183#issuecomment-1685258557

   Thanks all! I'll resume creating PRs, create issues for new overarching themes, and use my best judgement when a change grows beyond trivial for a particular project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-scm] timtebeek commented on pull request #183: [MNG-6829] Replace trimmed StringUtils#isEmpty(String) and #isNotEmpy

Posted by "timtebeek (via GitHub)" <gi...@apache.org>.
timtebeek commented on PR #183:
URL: https://github.com/apache/maven-scm/pull/183#issuecomment-1685253512

   Hi @olamy ; Thanks for voicing your concern with regards to consistently tagging issues with an appropriate Jira ticket as per the project. It's a valid concern, and it's come up before; I'll link to a few earlier discussions here.
   
   - https://github.com/apache/maven-scm/pull/183#issuecomment-1685231834
   - https://issues.apache.org/jira/browse/MNG-6825?focusedCommentId=17707546&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17707546
   - https://issues.apache.org/jira/browse/MNG-6825?focusedCommentId=17707549&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17707549
   
   I'll give a bit more context about these changes here, as I don't think we've met before. I work on OpenRewrite, which allows folks to make safe automated code changes. Together with the Moderne platform, that allows me to apply changes broadly with ease. I'm using these two tools to for instance work on
   
   - https://issues.apache.org/jira/browse/MNG-6825
     reduce dependencies on plexus-utils/maven-shared-utils/commons-lang3/commons-io
   - https://issues.apache.org/jira/browse/MNG-6829
     Remove commons-lang3 dependency
   - https://issues.apache.org/jira/browse/MNG-6847
     Explicit type can be replaced by the diamond operator
   
   There's a few others I'd like to tackle in the future with automated changes, such as for instance
   - https://issues.apache.org/jira/browse/MNG-7077
     the PlexusTestCase as a parent class should be transformed into a proper junit 5 extension
   
   All of these are small individual changes, that have often been applied to a subset of projects already, some by hand, some with tooling support. But given that there's some ~90 Apache Maven repositories, you'll find projects in various states.
   
   What I hope to do is lift all projects up to a common consistent state, such that they are all easier to maintain going forward. As per an earlier request I'm pushing frequent small PRs such that they are easier to review & troubleshoot if ever needed. That does mean a lot of PRs will be created, especially when replacing individual Plexus/Shared/Commons utilities methods.
   
   The parts that are automated right now are making the code changes, and creating PRs through the Moderne platform, both of which already existed before this effort. There's no easy way to hook in Jira issue creation right now, and for a lot of these changes an issue per project would only amount to as much as the PRs title & body already contain. That's why in the earlier discussions we'd arrived at using a common issue across projects for reference, such that they are all linked back to a single effort across many projects.
   
   Does that help put the above changes into context? And would you then agree with us continuing in the manner?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [maven-scm] olamy commented on pull request #183: [MNG-6829] Replace trimmed StringUtils#isEmpty(String) and #isNotEmpy

Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy commented on PR #183:
URL: https://github.com/apache/maven-scm/pull/183#issuecomment-1685254571

   @timtebeek I'm definitely fine with doing so for such trivial changes BUT this need to be agreed/recorded somewhere on a mailing list so nobody will get back on this complaining about the lack of Jira for this. 
   Having it on release notes could be great though (if possible)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org