[GitHub] [pinot] ankitsultana commented on issue #11145: Lock Contention in Controller During Realtime Segment Commit Events

["ankitsultana (via GitHub)" <gi...@apache.org>]

ankitsultana commented on issue #11145:
URL: https://github.com/apache/pinot/issues/11145#issuecomment-1734641682

   Just for clarity, our particular issue was due to the [IS update lock](https://github.com/apache/pinot/blob/723b764bc91275c0b8361d3f9135f151b6404c39/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java#L594)
   
   The PR #11679 removes the FSM lock: did you find that to be the bottleneck for some use-case?
   
   The FSM lock isn't technically global and uses striping (num-locks=20) with segmentName as the hash key. Also the ops done under the lock should be relatively quite quick, so wondering if there'll be much improvement (since IS update will continue to be the bottleneck).
   
   It's been a while since I looked into this so I might need to take a deeper look if more context is needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org