You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/07/21 17:37:47 UTC
[GitHub] [hive] aasha opened a new pull request #1289: HIVE-23863 : UGI doAs privilege action to make calls to Ranger Service
aasha opened a new pull request #1289:
URL: https://github.com/apache/hive/pull/1289
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HIVE-XXXXX: Fix a typo in YYY)
For more details, please see https://cwiki.apache.org/confluence/display/Hive/HowToContribute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #1289: HIVE-23863 : UGI doAs privilege action to make calls to Ranger Service
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1289:
URL: https://github.com/apache/hive/pull/1289#issuecomment-698046722
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha commented on a change in pull request #1289: HIVE-23863 : UGI doAs privilege action to make calls to Ranger Service
Posted by GitBox <gi...@apache.org>.
aasha commented on a change in pull request #1289:
URL: https://github.com/apache/hive/pull/1289#discussion_r458982494
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/ReplicationMetricCollector.java
##########
@@ -77,6 +77,9 @@ public void reportStageEnd(String stageName, Status status, long lastReplId) thr
Stage stage = progress.getStageByName(stageName);
stage.setStatus(status);
stage.setEndTime(System.currentTimeMillis());
+ if (Status.FAILED == status) {
Review comment:
If the stage has failed, the overall state should also be failed. Now it remains in progress. Noticed during testing this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha commented on a change in pull request #1289: HIVE-23863 : UGI doAs privilege action to make calls to Ranger Service
Posted by GitBox <gi...@apache.org>.
aasha commented on a change in pull request #1289:
URL: https://github.com/apache/hive/pull/1289#discussion_r459415724
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java
##########
@@ -79,6 +80,7 @@ public AtlasDumpTask() {
@Override
public int execute() {
try {
+ SecurityUtils.reloginExpiringKeytabUser();
Review comment:
Added
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/ReplicationMetricCollector.java
##########
@@ -77,6 +77,9 @@ public void reportStageEnd(String stageName, Status status, long lastReplId) thr
Stage stage = progress.getStageByName(stageName);
stage.setStatus(status);
stage.setEndTime(System.currentTimeMillis());
+ if (Status.FAILED == status) {
Review comment:
Added
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha commented on a change in pull request #1289: HIVE-23863 : UGI doAs privilege action to make calls to Ranger Service
Posted by GitBox <gi...@apache.org>.
pkumarsinha commented on a change in pull request #1289:
URL: https://github.com/apache/hive/pull/1289#discussion_r459208582
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java
##########
@@ -79,6 +80,7 @@ public AtlasDumpTask() {
@Override
public int execute() {
try {
+ SecurityUtils.reloginExpiringKeytabUser();
Review comment:
Should we have it for Atlas retries as well?
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/ReplicationMetricCollector.java
##########
@@ -77,6 +77,9 @@ public void reportStageEnd(String stageName, Status status, long lastReplId) thr
Stage stage = progress.getStageByName(stageName);
stage.setStatus(status);
stage.setEndTime(System.currentTimeMillis());
+ if (Status.FAILED == status) {
Review comment:
Sure. Can we have a test for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha commented on a change in pull request #1289: HIVE-23863 : UGI doAs privilege action to make calls to Ranger Service
Posted by GitBox <gi...@apache.org>.
aasha commented on a change in pull request #1289:
URL: https://github.com/apache/hive/pull/1289#discussion_r458982900
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java
##########
@@ -79,6 +80,7 @@ public AtlasDumpTask() {
@Override
public int execute() {
try {
+ SecurityUtils.reloginExpiringKeytabUser();
Review comment:
Yes its there as part of the retry as well. This is to make sure any file system calls happening before that is taken care of.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #1289: HIVE-23863 : UGI doAs privilege action to make calls to Ranger Service
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1289:
URL: https://github.com/apache/hive/pull/1289
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha commented on a change in pull request #1289: HIVE-23863 : UGI doAs privilege action to make calls to Ranger Service
Posted by GitBox <gi...@apache.org>.
pkumarsinha commented on a change in pull request #1289:
URL: https://github.com/apache/hive/pull/1289#discussion_r458964119
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/ReplicationMetricCollector.java
##########
@@ -77,6 +77,9 @@ public void reportStageEnd(String stageName, Status status, long lastReplId) thr
Stage stage = progress.getStageByName(stageName);
stage.setStatus(status);
stage.setEndTime(System.currentTimeMillis());
+ if (Status.FAILED == status) {
Review comment:
Could you please give background of this?
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/AtlasDumpTask.java
##########
@@ -79,6 +80,7 @@ public AtlasDumpTask() {
@Override
public int execute() {
try {
+ SecurityUtils.reloginExpiringKeytabUser();
Review comment:
Should it be more closure to the actual usage. Meaning, if we are doing a retry inside the task(Repl/Ranger/Atlas) somewhere, should it be closer to where we are actually interacting with external system?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org