[jira] Commented: (PORTLETBRIDGE-23) Add ability to redirect during render + execute phase listener when not calling lifecycle.execute

["Martin Marinschek (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/PORTLETBRIDGE-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569905#action_12569905 ] 

Martin Marinschek commented on PORTLETBRIDGE-23:
------------------------------------------------

Hi Mike,

I just reviewed your change, and it looks good - except:

+      // using the cached view.  Still call the preRestoreView phase listeners
+      // as some extensions depend on this being called per request.
+      PhaseListener[] listeners = lifecycle.getPhaseListeners();
+      PhaseEvent event = new PhaseEvent(context, PhaseId.RESTORE_VIEW, lifecycle);
+      for (PhaseListener listener:listeners)
+      {
+        listener.beforePhase(event);
+      }

the line listener.beforePhase() should only be called if the listener.getPhaseId() returns ANY_PHASE or RESTORE_VIEW - it is our responsibility to check this before calling this method.

regards,

Martin

> Add ability to redirect during render + execute phase listener when not calling lifecycle.execute
> -------------------------------------------------------------------------------------------------
>
>                 Key: PORTLETBRIDGE-23
>                 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-23
>             Project: MyFaces Portlet Bridge
>          Issue Type: New Feature
>          Components: Impl
>    Affects Versions: 1.0.0-SNAPSHOT
>            Reporter: Michael Freedman
>             Fix For: 1.0.0-SNAPSHOT
>
>         Attachments: jira_23.patch
>
>
> Add ability to redirect during a render (local navigation)
> Call (before) phase listener in render when not calling lifecycle.execute()
> Misc changes to sync with updated version of the spec.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.