[GitHub] [kafka] drawxy commented on a diff in pull request #13847: KAFKA-15082: The log retention policy doesn't take effect after altering log dir

["drawxy (via GitHub)" <gi...@apache.org>]

drawxy commented on code in PR #13847:
URL: https://github.com/apache/kafka/pull/13847#discussion_r1235160754


##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -881,6 +881,7 @@ class ReplicaManager(val config: KafkaConfig,
               if (partition.futureReplicaDirChanged(destinationDir)) {
                 replicaAlterLogDirsManager.removeFetcherForPartitions(Set(topicPartition))
                 partition.removeFutureLocalReplica()
+                logManager.resumeCleaning(topicPartition)

Review Comment:
   This statement is for canceling altering log dir (raising an alter log dir request whose future log dir is the current log dir). If we don't resume cleaning here, it will never be resumed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org