You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "BiteTheDDDDt (via GitHub)" <gi...@apache.org> on 2023/12/18 10:54:46 UTC
[PR] [Chore](execute) remove some unused code and adjust check_row_nums [doris]
BiteTheDDDDt opened a new pull request, #28576:
URL: https://github.com/apache/doris/pull/28576
## Proposed changes
remove some unused code and adjust check_row_nums
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore](execute) remove some unused code and adjust check_row_nums [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28576:
URL: https://github.com/apache/doris/pull/28576#issuecomment-1860597171
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore](execute) remove some unused code and adjust check_row_nums [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28576:
URL: https://github.com/apache/doris/pull/28576#issuecomment-1860597055
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore](execute) remove some unused code and adjust check_row_nums [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28576:
URL: https://github.com/apache/doris/pull/28576#issuecomment-1860290737
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.93 seconds
stream load tsv: 575 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17219129617 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore](execute) remove some unused code and adjust check_row_nums [doris]
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt commented on PR #28576:
URL: https://github.com/apache/doris/pull/28576#issuecomment-1860136750
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore](execute) remove some unused code and adjust check_row_nums [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28576:
URL: https://github.com/apache/doris/pull/28576#issuecomment-1860161902
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore](execute) remove some unused code and adjust check_row_nums [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28576:
URL: https://github.com/apache/doris/pull/28576#issuecomment-1860252687
TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Tpch sf100 test result on commit b0207e0b02dc16d97c3ddfacf74919088a1268f6, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4786 4429 4458 4429
q2 374 184 155 155
q3 1473 1280 1274 1274
q4 1108 922 878 878
q5 3152 3199 3201 3199
q6 245 133 125 125
q7 984 490 476 476
q8 2233 2237 2218 2218
q9 6741 6693 6690 6690
q10 3222 3262 3272 3262
q11 320 209 194 194
q12 355 210 209 209
q13 4572 3823 3785 3785
q14 243 214 215 214
q15 562 517 521 517
q16 438 390 381 381
q17 1019 647 571 571
q18 7241 7008 6992 6992
q19 1542 1484 1358 1358
q20 549 322 275 275
q21 3066 2639 2645 2639
q22 357 297 287 287
Total cold run time: 44582 ms
Total hot run time: 40128 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4397 4419 4399 4399
q2 269 161 173 161
q3 3547 3533 3514 3514
q4 2381 2378 2375 2375
q5 5738 5747 5755 5747
q6 242 121 124 121
q7 2383 1915 1841 1841
q8 3528 3534 3530 3530
q9 9028 9015 9001 9001
q10 3889 4023 3983 3983
q11 514 393 387 387
q12 769 600 609 600
q13 4305 3594 3557 3557
q14 289 255 255 255
q15 562 520 516 516
q16 506 450 453 450
q17 1885 1857 1824 1824
q18 8594 8287 8294 8287
q19 1707 1753 1762 1753
q20 2236 1941 1927 1927
q21 6552 6193 6163 6163
q22 513 443 430 430
Total cold run time: 63834 ms
Total hot run time: 60821 ms
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore](execute) remove some unused code and adjust check_row_nums [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #28576:
URL: https://github.com/apache/doris/pull/28576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org