You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by br...@us.ibm.com on 2012/05/01 19:57:22 UTC
Review Request: Origination info for OAuthRequest exchange token request
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4949/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
Add an AnonymousSecurityToken to the OAuthRequest exchange request. This was missed in SHINDIG-1756
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java 1331477
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/testing/FakeOAuthServiceProvider.java 1331477
Diff: https://reviews.apache.org/r/4949/diff
Testing
-------
Existing tests passed. OAuthRequestTest updated.
Thanks,
BrianLillie
Re: Review Request: Origination info for OAuthRequest exchange token request
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4949/#review7445
-----------------------------------------------------------
Ship it!
LGTM
- Ryan
On 2012-05-01 17:57:22, BrianLillie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4949/
> -----------------------------------------------------------
>
> (Updated 2012-05-01 17:57:22)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Add an AnonymousSecurityToken to the OAuthRequest exchange request. This was missed in SHINDIG-1756
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java 1331477
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/testing/FakeOAuthServiceProvider.java 1331477
>
> Diff: https://reviews.apache.org/r/4949/diff
>
>
> Testing
> -------
>
> Existing tests passed. OAuthRequestTest updated.
>
>
> Thanks,
>
> BrianLillie
>
>
Re: Review Request: Origination info for OAuthRequest exchange token request
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4949/#review7471
-----------------------------------------------------------
Ship it!
Committed revision 1333101.
Please mark this review as submitted. Thanks.
- Stanton
On 2012-05-02 16:19:28, BrianLillie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4949/
> -----------------------------------------------------------
>
> (Updated 2012-05-02 16:19:28)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Add an AnonymousSecurityToken to the OAuthRequest exchange request. This was missed in SHINDIG-1756
>
>
> This addresses bug SHINDIG-1764.
> https://issues.apache.org/jira/browse/SHINDIG-1764
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java 1331477
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/testing/FakeOAuthServiceProvider.java 1331477
>
> Diff: https://reviews.apache.org/r/4949/diff
>
>
> Testing
> -------
>
> Existing tests passed. OAuthRequestTest updated.
>
>
> Thanks,
>
> BrianLillie
>
>
Re: Review Request: Origination info for OAuthRequest exchange token request
Posted by br...@us.ibm.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4949/
-----------------------------------------------------------
(Updated 2012-05-02 16:19:28.366547)
Review request for shindig.
Summary
-------
Add an AnonymousSecurityToken to the OAuthRequest exchange request. This was missed in SHINDIG-1756
This addresses bug SHINDIG-1764.
https://issues.apache.org/jira/browse/SHINDIG-1764
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java 1331477
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/testing/FakeOAuthServiceProvider.java 1331477
Diff: https://reviews.apache.org/r/4949/diff
Testing
-------
Existing tests passed. OAuthRequestTest updated.
Thanks,
BrianLillie
Re: Review Request: Origination info for OAuthRequest exchange token request
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4949/#review7431
-----------------------------------------------------------
Ship it!
LGTM.
- Stanton
On 2012-05-01 17:57:22, BrianLillie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4949/
> -----------------------------------------------------------
>
> (Updated 2012-05-01 17:57:22)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Add an AnonymousSecurityToken to the OAuthRequest exchange request. This was missed in SHINDIG-1756
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java 1331477
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth/testing/FakeOAuthServiceProvider.java 1331477
>
> Diff: https://reviews.apache.org/r/4949/diff
>
>
> Testing
> -------
>
> Existing tests passed. OAuthRequestTest updated.
>
>
> Thanks,
>
> BrianLillie
>
>