You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Gregory Chanan <gc...@cloudera.com> on 2014/05/06 02:32:02 UTC
Review Request 21096: SENTRY-192: Convert solr doc-level e2e test to be
based on roles rather than groups
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21096/
-----------------------------------------------------------
Review request for sentry and Vamsee Yarlagadda.
Repository: sentry
Description
-------
Pretty straightforward change; updated TestDocLevelOperations to be based on roles rather than groups.
Also updated the solrconfig files to match the latest state.
Diffs
-----
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestDocLevelOperations.java 2c0914ed2f634047b3f196e54e354d7e6141b80a
sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/solrconfig-doclevel.xml 7c0d73f1b134e3fe8e6b589ecc48433fd489543d
sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/solrconfig.xml 9e71f099fda1718a9cbd8d97f850c2f24e15be36
sentry-tests/sentry-tests-solr/src/test/resources/solr/sentry/test-authz-provider.ini a07fb2dfef6258678d647491a756dbcf51d133d4
Diff: https://reviews.apache.org/r/21096/diff/
Testing
-------
Ran the solr e2e tests.
Thanks,
Gregory Chanan
Re: Review Request 21096: SENTRY-192: Convert solr doc-level e2e test to be
based on roles rather than groups
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21096/#review42316
-----------------------------------------------------------
Ship it!
Ship It!
- Vamsee Yarlagadda
On May 6, 2014, 5:10 p.m., Gregory Chanan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21096/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 5:10 p.m.)
>
>
> Review request for sentry and Vamsee Yarlagadda.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Pretty straightforward change; updated TestDocLevelOperations to be based on roles rather than groups.
> Also updated the solrconfig files to match the latest state.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestDocLevelOperations.java 2c0914ed2f634047b3f196e54e354d7e6141b80a
> sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/solrconfig-doclevel.xml 7c0d73f1b134e3fe8e6b589ecc48433fd489543d
> sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/solrconfig.xml 9e71f099fda1718a9cbd8d97f850c2f24e15be36
> sentry-tests/sentry-tests-solr/src/test/resources/solr/sentry/test-authz-provider.ini a07fb2dfef6258678d647491a756dbcf51d133d4
>
> Diff: https://reviews.apache.org/r/21096/diff/
>
>
> Testing
> -------
>
> Ran the solr e2e tests.
>
>
> Thanks,
>
> Gregory Chanan
>
>
Re: Review Request 21096: SENTRY-192: Convert solr doc-level e2e test to be
based on roles rather than groups
Posted by Gregory Chanan <gc...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21096/
-----------------------------------------------------------
(Updated May 6, 2014, 5:10 p.m.)
Review request for sentry and Vamsee Yarlagadda.
Changes
-------
Updated comment in the solrconfig to refer to role rather than group. Thanks for the suggestion, Vamsee.
Repository: sentry
Description
-------
Pretty straightforward change; updated TestDocLevelOperations to be based on roles rather than groups.
Also updated the solrconfig files to match the latest state.
Diffs (updated)
-----
sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestDocLevelOperations.java 2c0914ed2f634047b3f196e54e354d7e6141b80a
sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/solrconfig-doclevel.xml 7c0d73f1b134e3fe8e6b589ecc48433fd489543d
sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/solrconfig.xml 9e71f099fda1718a9cbd8d97f850c2f24e15be36
sentry-tests/sentry-tests-solr/src/test/resources/solr/sentry/test-authz-provider.ini a07fb2dfef6258678d647491a756dbcf51d133d4
Diff: https://reviews.apache.org/r/21096/diff/
Testing
-------
Ran the solr e2e tests.
Thanks,
Gregory Chanan
Re: Review Request 21096: SENTRY-192: Convert solr doc-level e2e test to be
based on roles rather than groups
Posted by Vamsee Yarlagadda <va...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21096/#review42286
-----------------------------------------------------------
sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/solrconfig-doclevel.xml
<https://reviews.apache.org/r/21096/#comment76062>
Auth token defined to allow any *roles* to access the document.
"group" -> "roles"
sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/solrconfig.xml
<https://reviews.apache.org/r/21096/#comment76063>
Auth token defined to allow any *roles* to access the document.
"group" -> "roles"
- Vamsee Yarlagadda
On May 6, 2014, 12:31 a.m., Gregory Chanan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21096/
> -----------------------------------------------------------
>
> (Updated May 6, 2014, 12:31 a.m.)
>
>
> Review request for sentry and Vamsee Yarlagadda.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Pretty straightforward change; updated TestDocLevelOperations to be based on roles rather than groups.
> Also updated the solrconfig files to match the latest state.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/TestDocLevelOperations.java 2c0914ed2f634047b3f196e54e354d7e6141b80a
> sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/solrconfig-doclevel.xml 7c0d73f1b134e3fe8e6b589ecc48433fd489543d
> sentry-tests/sentry-tests-solr/src/test/resources/solr/collection1/conf/solrconfig.xml 9e71f099fda1718a9cbd8d97f850c2f24e15be36
> sentry-tests/sentry-tests-solr/src/test/resources/solr/sentry/test-authz-provider.ini a07fb2dfef6258678d647491a756dbcf51d133d4
>
> Diff: https://reviews.apache.org/r/21096/diff/
>
>
> Testing
> -------
>
> Ran the solr e2e tests.
>
>
> Thanks,
>
> Gregory Chanan
>
>