You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Stefano Bagnara (JIRA)" <se...@james.apache.org> on 2005/05/30 09:19:02 UTC

[jira] Created: (JAMES-379) MailImpl.duplicate() should also clone attributes and not only the container HashMap

MailImpl.duplicate() should also clone attributes and not only the container HashMap
------------------------------------------------------------------------------------

         Key: JAMES-379
         URL: http://issues.apache.org/jira/browse/JAMES-379
     Project: James
        Type: Bug
  Components: James Core  
    Versions: 2.2.0    
    Reporter: Stefano Bagnara
    Priority: Minor


Probably currently we are using only String attributes and Strings are immutable so we never hit the bug. I recently added a complex object to the attributes and I noticed this.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Updated: (JAMES-379) MailImpl.duplicate() should also clone attributes and not only the container HashMap

Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
     [ http://issues.apache.org/jira/browse/JAMES-379?page=all ]

Stefano Bagnara updated JAMES-379:
----------------------------------

    Attachment: MailImpl.java.duplicatefix.diff

I already coded something but had no time to test it!
Here is the simple patch.

I will probably test it the next weekend.

> MailImpl.duplicate() should also clone attributes and not only the container HashMap
> ------------------------------------------------------------------------------------
>
>          Key: JAMES-379
>          URL: http://issues.apache.org/jira/browse/JAMES-379
>      Project: James
>         Type: Bug
>   Components: James Core
>     Versions: 2.2.0
>     Reporter: Stefano Bagnara
>     Assignee: Noel J. Bergman
>     Priority: Minor
>  Attachments: MailImpl.java.duplicatefix.diff
>
> Probably currently we are using only String attributes and Strings are immutable so we never hit the bug. I recently added a complex object to the attributes and I noticed this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Assigned: (JAMES-379) MailImpl.duplicate() should also clone attributes and not only the container HashMap

Posted by "Noel J. Bergman (JIRA)" <se...@james.apache.org>.
     [ http://issues.apache.org/jira/browse/JAMES-379?page=all ]

Noel J. Bergman reassigned JAMES-379:
-------------------------------------

    Assign To: Noel J. Bergman

> MailImpl.duplicate() should also clone attributes and not only the container HashMap
> ------------------------------------------------------------------------------------
>
>          Key: JAMES-379
>          URL: http://issues.apache.org/jira/browse/JAMES-379
>      Project: James
>         Type: Bug
>   Components: James Core
>     Versions: 2.2.0
>     Reporter: Stefano Bagnara
>     Assignee: Noel J. Bergman
>     Priority: Minor

>
> Probably currently we are using only String attributes and Strings are immutable so we never hit the bug. I recently added a complex object to the attributes and I noticed this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Resolved: (JAMES-379) MailImpl.duplicate() should also clone attributes and not only the container HashMap

Posted by "Noel J. Bergman (JIRA)" <se...@james.apache.org>.
     [ http://issues.apache.org/jira/browse/JAMES-379?page=all ]
     
Noel J. Bergman resolved JAMES-379:
-----------------------------------

    Resolution: Fixed

Fix applied to SVN.

> MailImpl.duplicate() should also clone attributes and not only the container HashMap
> ------------------------------------------------------------------------------------
>
>          Key: JAMES-379
>          URL: http://issues.apache.org/jira/browse/JAMES-379
>      Project: James
>         Type: Bug
>   Components: James Core
>     Versions: 2.2.0
>     Reporter: Stefano Bagnara
>     Assignee: Noel J. Bergman
>     Priority: Minor
>      Fix For: 3.0
>  Attachments: MailImpl.java.duplicatefix.diff, MailImplTest.java
>
> Probably currently we are using only String attributes and Strings are immutable so we never hit the bug. I recently added a complex object to the attributes and I noticed this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Commented: (JAMES-379) MailImpl.duplicate() should also clone attributes and not only the container HashMap

Posted by "Noel J. Bergman (JIRA)" <se...@james.apache.org>.
     [ http://issues.apache.org/jira/browse/JAMES-379?page=comments#action_66576 ]
     
Noel J. Bergman commented on JAMES-379:
---------------------------------------

Stefano, I've assigned this to myself.  Do you have a patch for this that I can apply?  :-)  If so, please attach.

> MailImpl.duplicate() should also clone attributes and not only the container HashMap
> ------------------------------------------------------------------------------------
>
>          Key: JAMES-379
>          URL: http://issues.apache.org/jira/browse/JAMES-379
>      Project: James
>         Type: Bug
>   Components: James Core
>     Versions: 2.2.0
>     Reporter: Stefano Bagnara
>     Assignee: Noel J. Bergman
>     Priority: Minor

>
> Probably currently we are using only String attributes and Strings are immutable so we never hit the bug. I recently added a complex object to the attributes and I noticed this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Updated: (JAMES-379) MailImpl.duplicate() should also clone attributes and not only the container HashMap

Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
     [ http://issues.apache.org/jira/browse/JAMES-379?page=all ]

Stefano Bagnara updated JAMES-379:
----------------------------------

    Attachment: MailImplTest.java

Test case for the bug fixed.

> MailImpl.duplicate() should also clone attributes and not only the container HashMap
> ------------------------------------------------------------------------------------
>
>          Key: JAMES-379
>          URL: http://issues.apache.org/jira/browse/JAMES-379
>      Project: James
>         Type: Bug
>   Components: James Core
>     Versions: 2.2.0
>     Reporter: Stefano Bagnara
>     Assignee: Noel J. Bergman
>     Priority: Minor
>  Attachments: MailImpl.java.duplicatefix.diff, MailImplTest.java
>
> Probably currently we are using only String attributes and Strings are immutable so we never hit the bug. I recently added a complex object to the attributes and I noticed this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Updated: (JAMES-379) MailImpl.duplicate() should also clone attributes and not only the container HashMap

Posted by "Noel J. Bergman (JIRA)" <se...@james.apache.org>.
     [ http://issues.apache.org/jira/browse/JAMES-379?page=all ]

Noel J. Bergman updated JAMES-379:
----------------------------------

    Fix Version: 3.0

> MailImpl.duplicate() should also clone attributes and not only the container HashMap
> ------------------------------------------------------------------------------------
>
>          Key: JAMES-379
>          URL: http://issues.apache.org/jira/browse/JAMES-379
>      Project: James
>         Type: Bug
>   Components: James Core
>     Versions: 2.2.0
>     Reporter: Stefano Bagnara
>     Assignee: Noel J. Bergman
>     Priority: Minor
>      Fix For: 3.0
>  Attachments: MailImpl.java.duplicatefix.diff, MailImplTest.java
>
> Probably currently we are using only String attributes and Strings are immutable so we never hit the bug. I recently added a complex object to the attributes and I noticed this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Updated: (JAMES-379) MailImpl.duplicate() should also clone attributes and not only the container HashMap

Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
     [ http://issues.apache.org/jira/browse/JAMES-379?page=all ]

Stefano Bagnara updated JAMES-379:
----------------------------------

    Fix Version: 2.2.1
                     (was: 3.0)

> MailImpl.duplicate() should also clone attributes and not only the container HashMap
> ------------------------------------------------------------------------------------
>
>          Key: JAMES-379
>          URL: http://issues.apache.org/jira/browse/JAMES-379
>      Project: James
>         Type: Bug
>   Components: James Core
>     Versions: 2.2.0
>     Reporter: Stefano Bagnara
>     Assignee: Noel J. Bergman
>     Priority: Minor
>      Fix For: 2.2.1
>  Attachments: MailImpl.java.duplicatefix.diff, MailImplTest.java
>
> Probably currently we are using only String attributes and Strings are immutable so we never hit the bug. I recently added a complex object to the attributes and I noticed this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org