[jira] Commented: (THRIFT-131) Add convenience counter methods to fb303 thrift file

["Johan Oskarsson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628341#action_12628341 ] 

Johan Oskarsson commented on THRIFT-131:
----------------------------------------

Description got mangled, but you get my point.
I'll hope to have some time to implement this, but wanted to know if this goes against some thrift "keep it clean"-policy before I start.

Alternative to i64 incrementCounter(string key) would be: i64 incrementCounter(string key, i64 increment);

> Add convenience counter methods to fb303 thrift file
> ----------------------------------------------------
>
>                 Key: THRIFT-131
>                 URL: https://issues.apache.org/jira/browse/THRIFT-131
>             Project: Thrift
>          Issue Type: Improvement
>            Reporter: Johan Oskarsson
>            Priority: Trivial
>
> Since most of the different FacebookBase classes/files have a version of these methods, I suggest adding them to the fb303.thrift file.
> /**
>  * increment this counter by 1
>  */
> i64 incrementCounter(String key);
> /**
>  * Remove this counter and any value associated with it
>  */
> void deleteCounter(string key);
> /**
>  * Reset this counter to 0
>  */
> void resetCounter(string key);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.