[GitHub] [geode] jujoramos opened pull request #4030: GEODE-6984: Make OQL Security API Public

["jujoramos (GitHub)" <gi...@apache.org>]

- Moved 'MethodInvocationAuthorizer' and 'RestrictedMethodAuthorizer'
  from an internal package to a public one,
  'org.apache.geode.cache.query.security'.
- Addded javadocs for MethodInvocationAuthorizer.
- Fixed warnings and added Unit Tests for MethodDispatch.
- Fixed warnings and added Unit Tests for AttributeDescriptor.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4030 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jujoramos commented on pull request #4030: GEODE-6984: Make OQL Security API Public

["jujoramos (GitHub)" <gi...@apache.org>]

Done!.

[ Full content available at: https://github.com/apache/geode/pull/4030 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jujoramos commented on pull request #4030: GEODE-6984: Make OQL Security API Public

["jujoramos (GitHub)" <gi...@apache.org>]

The test is trying to (implicitly) invoke the method `values()` on the `Region` object within the query: `"select v from $1 r, r.values() v"`, that's where it comes from.

[ Full content available at: https://github.com/apache/geode/pull/4030 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jujoramos closed pull request #4030: GEODE-6984: Make OQL Security API Public

["jujoramos (GitHub)" <gi...@apache.org>]

[ pull request closed by jujoramos ]

[ Full content available at: https://github.com/apache/geode/pull/4030 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jhuynh1 commented on pull request #4030: GEODE-6984: Make OQL Security API Public

["jhuynh1 (GitHub)" <gi...@apache.org>]

Ultra nitpick: very short line, combine with another line and reapply formatting?

[ Full content available at: https://github.com/apache/geode/pull/4030 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jhuynh1 commented on pull request #4030: GEODE-6984: Make OQL Security API Public

["jhuynh1 (GitHub)" <gi...@apache.org>]

typo, duplicate "on on" 

[ Full content available at: https://github.com/apache/geode/pull/4030 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jujoramos commented on pull request #4030: GEODE-6984: Make OQL Security API Public

["jujoramos (GitHub)" <gi...@apache.org>]

Done!.

[ Full content available at: https://github.com/apache/geode/pull/4030 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org