[jira] [Updated] (OAK-5784) hashCode of RestrictionImpl doesn't include value

["angela (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-5784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela updated OAK-5784:
------------------------
    Summary: hashCode of RestrictionImpl doesn't include value  (was: HashCode of access control entry and ac-entries in PermissionHook doesn't include the Restriction value)

> hashCode of RestrictionImpl doesn't include value
> -------------------------------------------------
>
>                 Key: OAK-5784
>                 URL: https://issues.apache.org/jira/browse/OAK-5784
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: angela
>            Assignee: angela
>             Fix For: 1.8
>
>
> The hashCode generation of {{RestrictionImpl}} currently looks as follows:
> {code}
>     public int hashCode() {
>         return Objects.hashCode(definition, property);
>     }
> {code}
> However, the hashCode of our {{PropertyState}} implementation doesn't include the value. See {{AbstractPropertyState}}:
> {code}
> public static int hashCode(PropertyState property) {
>         return property.getName().hashCode();
>     }
> {code}
> Consequently the hashCode of the {{AccessControlEntry}} implementation and the {{AcEntry}} created in the PermissionHook generates the same code for entries that only differ by the value of a restriction.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)