[GitHub] [couchdb] nickva commented on a diff in pull request #4782: fix(`mango`): prevent occasional duplication of paginated `text` results

["nickva (via GitHub)" <gi...@apache.org>]

nickva commented on code in PR #4782:
URL: https://github.com/apache/couchdb/pull/4782#discussion_r1340233331


##########
src/mango/src/mango_cursor_text.erl:
##########
@@ -108,7 +109,8 @@ execute(Cursor, UserFun, UserAcc) ->
         user_fun = UserFun,
         user_acc = UserAcc,
         fields = Cursor#cursor.fields,
-        execution_stats = mango_execution_stats:log_start(Stats)
+        execution_stats = mango_execution_stats:log_start(Stats),
+        documents_seen = #{}

Review Comment:
   Could use a set probably. Use version = 2 as it will be backed by a map anyway.
   
   https://www.erlang.org/docs/24/man/sets#new-1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org