You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by EronWright <gi...@git.apache.org> on 2017/09/05 15:41:11 UTC

[GitHub] flink issue #4636: [FLINK-2268] Allow Flink binary release without Hadoop

Github user EronWright commented on the issue:

    https://github.com/apache/flink/pull/4636
  
    Overall this looks great.  I looked for any signs of behavior changes, especially in the security code since there's some subtlety there, didn't notice any.  
    
    Please consider moving `SecurityUtils.SecurityConfiguration` to be a top-level class.
    
    Are you sure that you can check for a class (`forName`) and then use it normally?  I kinda thought that the classloader is more eager.


---