You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/02/12 15:58:34 UTC
[GitHub] ocket8888 opened a new pull request #3324: Hint for form fields is
now a help cursor instead of underline (which implies link)
ocket8888 opened a new pull request #3324: Hint for form fields is now a help cursor instead of underline (which implies link)
URL: https://github.com/apache/trafficcontrol/pull/3324
## Which issue is fixed by this PR? If not related to an existing issue, what does this PR do?
In Traffic Portal forms, when a help popover is available the UI indicates this by underlining the field label. This PR changes the hint to instead make the cursor appear as the system's default "help" cursor, indicating help on the topic available. The underline makes it seem like the text is a link, and clicking on it may navigate me away from the form.
## Which TC components are affected by this PR?
- [ ] Documentation
- [ ] Grove
- [ ] Traffic Analytics
- [ ] Traffic Monitor
- [ ] Traffic Ops
- [ ] Traffic Ops ORT
- [x] Traffic Portal
- [ ] Traffic Router
- [ ] Traffic Stats
- [ ] Traffic Vault
- [ ] Other _________
## What is the best way to verify this PR? Please include manual steps or automated tests.
Build and start Traffic Portal and check that the field label text is no longer underlined on hover, but instead transforms the cursor into your system's "help" cursor (usually a question mark of some kind).
## Check all that apply
- [ ] This PR includes tests
- [ ] This PR includes documentation updates
- [ ] This PR includes an update to CHANGELOG.md
- [ ] This PR includes all required license headers
- [ ] This PR includes a database migration (ensure that migration sequence is correct)
- [ ] This PR fixes a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services