[jira] [Commented] (ROCKETMQ-224) Client log4j2 logging

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108348#comment-16108348 ] 

ASF GitHub Bot commented on ROCKETMQ-224:
-----------------------------------------

Github user lizhanhui commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/120#discussion_r130515214
  
    --- Diff: client/src/test/java/org/apache/rocketmq/client/log/ClientLogTest.java ---
    @@ -0,0 +1,67 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.rocketmq.client.log;
    +
    +import junit.framework.Assert;
    --- End diff --
    
    We'd better use org.junit.Assert.


> Client log4j2 logging
> ---------------------
>
>                 Key: ROCKETMQ-224
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-224
>             Project: Apache RocketMQ
>          Issue Type: New Feature
>          Components: rocketmq-client
>    Affects Versions: 4.1.0-incubating
>         Environment: Jdk 1.7
>            Reporter: lindzh
>            Assignee: Xiaorui Wang
>             Fix For: 4.2.0-incubating
>
>
> When using RocketMQ client,we can only using logback or log4j for logging. If we using log4j2,there is no client log.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)